util: add DestinationChip and DestinationInputChip components #3586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you pls add to the description screenshots with the intended UX and the info for setup (experimental flag, mutation to have Dest types added, etc)? |
I updated the description to include screenshots and added additional context. This won't need any experiment flags to run. |
mastercactapus
previously approved these changes
Jan 9, 2024
Forfold
reviewed
Jan 10, 2024
added 2 commits
January 10, 2024 09:54
tony-tvu
dismissed stale reviews from ethan-haynes and mastercactapus
via
a0e8f3d
mastercactapus
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
This pull request introduces the DestinationChip and DestinationInputChip components, an addition that is essential for facilitating the development of generic destinations with pluggable providers. These components play a role in processing props such as icons, text, and cancel functions, and rendering them on the screen.
Which issue(s) this PR fixes:
Part of #2639
Screenshots:
Icon Variations:
Additional Info:
Run
make storybookto interact with new components.These components will be unused in main application functions, until we have wired them in with future component updates, e.g. PolicyStepDialog components.