Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: add DestinationChip and DestinationInputChip components #3586

Merged
merged 8 commits into from
Jan 12, 2024

Conversation

tony-tvu
Copy link
Collaborator

@tony-tvu tony-tvu commented Jan 9, 2024

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This pull request introduces the DestinationChip and DestinationInputChip components, an addition that is essential for facilitating the development of generic destinations with pluggable providers. These components play a role in processing props such as icons, text, and cancel functions, and rendering them on the screen.

Which issue(s) this PR fixes:
Part of #2639

Screenshots:
chips

Icon Variations:
icon variations

Additional Info:
Run make storybook to interact with new components.

These components will be unused in main application functions, until we have wired them in with future component updates, e.g. PolicyStepDialog components.

@github-actions github-actions bot added the size/l label Jan 9, 2024
@Forfold
Copy link
Contributor

Forfold commented Jan 9, 2024

Could you pls add to the description screenshots with the intended UX and the info for setup (experimental flag, mutation to have Dest types added, etc)?

@tony-tvu
Copy link
Collaborator Author

tony-tvu commented Jan 9, 2024

Could you pls add to the description screenshots with the intended UX and the info for setup (experimental flag, mutation to have Dest types added, etc)?

I updated the description to include screenshots and added additional context. This won't need any experiment flags to run.

mastercactapus
mastercactapus previously approved these changes Jan 9, 2024
ethan-haynes
ethan-haynes previously approved these changes Jan 10, 2024
Copy link
Collaborator

@ethan-haynes ethan-haynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

web/src/app/util/DestinationChip.tsx Outdated Show resolved Hide resolved
web/src/app/util/DestinationChip.tsx Show resolved Hide resolved
web/src/app/util/DestinationChip.tsx Show resolved Hide resolved
Copy link
Collaborator

@allending313 allending313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mastercactapus mastercactapus merged commit 8e7aeae into master Jan 12, 2024
7 checks passed
@mastercactapus mastercactapus deleted the destination-chips branch January 12, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants