Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selection: add DestinationField component and tests #3592

Merged
merged 17 commits into from
Jan 22, 2024

Conversation

tony-tvu
Copy link
Collaborator

@tony-tvu tony-tvu commented Jan 11, 2024

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This pull request introduces the DestinationField component, a crucial addition necessary to support the development of generic destinations with pluggable providers. The DestinationField component is designed to receive a destination type, such as single-field or multi-field destinations, as a prop and dynamically display the relevant information.

Which issue(s) this PR fixes:
Part of #2639

Screenshots:
Examples for single, multiple, and disabled destination types:
Screenshot 2024-01-16 at 2 41 31 PM

Additional Info:
Run make storybook to interact with DestinationField component.

This component will remain dormant within the main UI until they are integrated with upcoming component updates, such as the PolicyStepDialog components.

Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it so the fields in storybook are editable/can type in?

Also, we'll need to add padding to the multi-input fields:

Screenshot 2024-01-12 at 10 17 58 AM

@tony-tvu
Copy link
Collaborator Author

Can we make it so the fields in storybook are editable/can type in?

Also, we'll need to add padding to the multi-input fields:

Screenshot 2024-01-12 at 10 17 58 AM

You can't edit the fields on the Docs page because those are just snapshots of all the tests. You can edit the fields when you go into individual test.

mastercactapus
mastercactapus previously approved these changes Jan 17, 2024
mastercactapus
mastercactapus previously approved these changes Jan 17, 2024
@mastercactapus mastercactapus merged commit 280034b into master Jan 22, 2024
7 checks passed
@mastercactapus mastercactapus deleted the destinationfield branch January 22, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants