-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
selection: add DestinationField component and tests #3592
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forfold
requested changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forfold
reviewed
Jan 12, 2024
Forfold
reviewed
Jan 16, 2024
mastercactapus
previously approved these changes
Jan 17, 2024
mastercactapus
previously approved these changes
Jan 17, 2024
mastercactapus
approved these changes
Jan 19, 2024
Forfold
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make check
to catch common errors. Fixed any that came up.Description:
This pull request introduces the DestinationField component, a crucial addition necessary to support the development of generic destinations with pluggable providers. The DestinationField component is designed to receive a destination type, such as single-field or multi-field destinations, as a prop and dynamically display the relevant information.
Which issue(s) this PR fixes:
Part of #2639
Screenshots:
Examples for single, multiple, and disabled destination types:
Additional Info:
Run
make storybook
to interact with DestinationField component.This component will remain dormant within the main UI until they are integrated with upcoming component updates, such as the PolicyStepDialog components.