Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

users: use generic dests for user CM form, create, and edit dialogs #3661

Closed
wants to merge 4 commits into from

Conversation

tony-tvu
Copy link
Collaborator

@tony-tvu tony-tvu commented Feb 7, 2024

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR assumes #3660 has already been approved and merged to master branch. This PR updates the UserContactMethod form, create, and edit dialogs to use destinations when the experimental flag is set make start EXPERIMENTAL=dest-types.

Which issue(s) this PR fixes:
part of #2639

Out of Scope:
N/A

Screen
Screenshot 2024-02-07 at 10 19 28 AM
Screenshot 2024-02-07 at 10 19 20 AM
Screenshot 2024-02-07 at 10 19 12 AM
Screenshot 2024-02-07 at 10 18 47 AM
Screenshot 2024-02-07 at 10 18 35 AM
shots:

Describe any introduced user-facing changes:
N/A, behavior should be the same as today, with the exception of Slack now using the team/workspace icon instead of the generic slack icon.

Describe any introduced API changes:
N/A

Additional Info:
N/A

@tony-tvu
Copy link
Collaborator Author

tony-tvu commented Feb 7, 2024

Closing to split into separate PRs.

@tony-tvu tony-tvu closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant