Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dest: add API support to create EP step with destinations #3700

Merged
merged 16 commits into from
Feb 23, 2024

Conversation

tony-tvu
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR adds support for creating an escalation policy step using generic destinations when the experimental flag is set make start EXPERIMENTAL=dest-types.

Which issue(s) this PR fixes:
part of #2639

Out of Scope:
N/A

Screenshots:
N/A

Describe any introduced user-facing changes:
N/A

Describe any introduced API changes:
Added CreateEscalationPolicyStepInput resolver. Also added favoritesFirst field to DestinationFieldSearchInput schema to show favorites first when searching for rotations, schedules, and users.

Additional Info:
N/A

graphql2/graphqlapp/destinationtypes.go Outdated Show resolved Hide resolved
graphql2/graphqlapp/destinationtypes.go Outdated Show resolved Hide resolved
graphql2/graphqlapp/escalationpolicy.go Outdated Show resolved Hide resolved
graphql2/graphqlapp/escalationpolicy.go Outdated Show resolved Hide resolved
graphql2/graph/destinations.graphqls Outdated Show resolved Hide resolved
tony-tvu and others added 9 commits February 22, 2024 10:07
@github-actions github-actions bot added size/l and removed size/m labels Feb 23, 2024
@mastercactapus mastercactapus merged commit 91fc3a7 into master Feb 23, 2024
7 checks passed
@mastercactapus mastercactapus deleted the ep-step-create-dialog-dest-API branch February 23, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants