Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user contact method edit dialog dest #3720

Merged
merged 23 commits into from
Mar 25, 2024
Merged

user contact method edit dialog dest #3720

merged 23 commits into from
Mar 25, 2024

Conversation

ethan-haynes
Copy link
Collaborator

Description:
Adds the Edit dialog for user contact methods using the new dest API.

Which issue(s) this PR fixes:
Part of #2639

Screenshots:
Screenshot 2024-02-28 at 2 31 50 PM

@ethan-haynes ethan-haynes marked this pull request as draft February 28, 2024 21:34
@ethan-haynes ethan-haynes marked this pull request as ready for review March 6, 2024 19:59
mastercactapus
mastercactapus requested changes Mar 8, 2024
View reviewed changes
Copy link
Member

@mastercactapus mastercactapus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything's looking good code wise for the most part, but I noticed 2 issues functionally validating:

  • name field errors aren't showing up on the field

    image

  • The contact method list doesn't update on success (likely need additionalTypeNames: UserContactMethod)

mastercactapus
mastercactapus previously approved these changes Mar 11, 2024
View reviewed changes
@mastercactapus
Copy link
Member

Also to note: let's switch to use canvasElement instead of screen -- check some of the other examples for how to setup disablePortal to make that work

@ethan-haynes @Forfold
fix for default name
a332101 
Co-authored-by: Nathaniel Cook <NathanielJCook@outlook.com>
@ethan-haynes @mastercactapus
Update web/src/app/users/UserContactMethodEditDialogDest.tsx
2455e28 
Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
mastercactapus
mastercactapus previously approved these changes Mar 21, 2024
View reviewed changes
@mastercactapus mastercactapus merged commit b0eaae7 into master Mar 25, 2024
7 checks passed
@mastercactapus mastercactapus deleted the usr-cm-edit-dialog-dest branch March 25, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@mastercactapus mastercactapus mastercactapus approved these changes

@Forfold Forfold Forfold approved these changes

Assignees
No one assigned
Labels
size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ethan-haynes @mastercactapus @Forfold