lib: enforce use of primordial Number

PR-URL: nodejs#30700 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos · Nov 30, 2019 · 2070d3f · 2070d3f
1 parent 1f9a5ae
commit 2070d3f
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 1 deletion.
diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml
@@ -17,6 +17,8 @@ rules:
       message: "Use `const { JSON } = primordials;` instead of the global."
     - name: Math
       message: "Use `const { Math } = primordials;` instead of the global."
+    - name: Number
+      message: "Use `const { Number } = primordials;` instead of the global."
     - name: Object
       message: "Use `const { Object } = primordials;` instead of the global."
     - name: Reflect

diff --git a/lib/internal/buffer.js b/lib/internal/buffer.js
@@ -2,6 +2,7 @@
 
 const {
   MathFloor,
+  Number,
 } = primordials;
 
 const {

diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js
@@ -8,6 +8,7 @@ const {
   ArrayIsArray,
   Boolean,
   MathFloor,
+  Number,
   ObjectDefineProperties,
   ObjectDefineProperty,
   ObjectKeys,

diff --git a/lib/internal/fs/utils.js b/lib/internal/fs/utils.js
@@ -3,6 +3,7 @@
 const {
   ArrayIsArray,
   DateNow,
+  Number,
   NumberIsFinite,
   ObjectSetPrototypeOf,
   ReflectOwnKeys,

diff --git a/lib/internal/http2/util.js b/lib/internal/http2/util.js
@@ -3,6 +3,7 @@
 const {
   ArrayIsArray,
   MathMax,
+  Number,
   ObjectCreate,
   ObjectKeys,
 } = primordials;

diff --git a/lib/internal/repl.js b/lib/internal/repl.js
@@ -1,6 +1,7 @@
 'use strict';
 
 const {
+  Number,
   NumberIsNaN,
   ObjectCreate,
 } = primordials;

diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -2,6 +2,7 @@
 
 const {
   Array,
+  Number,
   ObjectCreate,
   ObjectDefineProperties,
   ObjectDefineProperty,

diff --git a/lib/internal/util/inspect.js b/lib/internal/util/inspect.js
@@ -16,6 +16,7 @@ const {
   MathMin,
   MathRound,
   MathSqrt,
+  Number,
   NumberIsNaN,
   NumberPrototypeValueOf,
   ObjectAssign,
@@ -39,7 +40,7 @@ const {
   SymbolPrototypeValueOf,
   SymbolIterator,
   SymbolToStringTag,
-  uncurryThis
+  uncurryThis,
 } = primordials;
 
 const {

diff --git a/lib/net.js b/lib/net.js
@@ -24,6 +24,7 @@
 const {
   ArrayIsArray,
   Boolean,
+  Number,
   NumberIsNaN,
   ObjectDefineProperty,
   ObjectSetPrototypeOf,
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,7 @@ @@
     const {
       MathFloor,
+      Number,
     } = primordials;
     const {
@@ Expand Down @@