Skip to content

Commit

Permalink
build: re-introduce --use-largepages as no-op
Browse files Browse the repository at this point in the history
Re-introduce the build-time option as a no-op in order to retain
backward compatibility for LTS purposes.

Backport-PR-URL: nodejs#32092
Re: nodejs#31063 (review)
PR_URL: nodejs#31075
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
Gabriel Schulhof authored and targos committed Apr 25, 2020
1 parent 9d425f0 commit 4d71000
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,16 @@
dest='with_etw',
help='build with ETW (default is true on Windows)')

parser.add_option('--use-largepages',
action='store_true',
dest='node_use_large_pages',
help='This option has no effect. --use-largepages is now a runtime option.')

parser.add_option('--use-largepages-script-lld',
action='store_true',
dest='node_use_large_pages_script_lld',
help='This option has no effect. --use-largepages is now a runtime option.')

intl_optgroup.add_option('--with-intl',
action='store',
dest='with_intl',
Expand Down

0 comments on commit 4d71000

Please sign in to comment.