Skip to content

Commit

Permalink
readline,repl: support tabs properly
Browse files Browse the repository at this point in the history
PR-URL: nodejs#31112
Fixes: nodejs#25272
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR authored and targos committed Apr 25, 2020

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
1 parent 689bcd1 commit 50a16ed
Showing 2 changed files with 21 additions and 24 deletions.
39 changes: 18 additions & 21 deletions lib/readline.js
Original file line number Diff line number Diff line change
@@ -490,9 +490,6 @@ Interface.prototype._insertString = function(c) {
} else {
this._writeToOutput(c);
}

// A hack to get the line refreshed if it's needed
this._moveCursor(0);
}
};

@@ -731,6 +728,12 @@ Interface.prototype._getDisplayPos = function(str) {
offset = 0;
continue;
}
// Tabs must be aligned by an offset of 8.
// TODO(BridgeAR): Make the tab size configurable.
if (char === '\t') {
offset += 8 - (offset % 8);
continue;
}
const width = getStringWidth(char);
if (width === 0 || width === 1) {
offset += width;
@@ -768,33 +771,27 @@ Interface.prototype._getCursorPos = Interface.prototype.getCursorPos;


// This function moves cursor dx places to the right
// (-dx for left) and refreshes the line if it is needed
// (-dx for left) and refreshes the line if it is needed.
Interface.prototype._moveCursor = function(dx) {
const oldcursor = this.cursor;
if (dx === 0) {
return;
}
const oldPos = this.getCursorPos();
this.cursor += dx;

// bounds check
if (this.cursor < 0) this.cursor = 0;
else if (this.cursor > this.line.length) this.cursor = this.line.length;
// Bounds check
if (this.cursor < 0) {
this.cursor = 0;
} else if (this.cursor > this.line.length) {
this.cursor = this.line.length;
}

const newPos = this.getCursorPos();

// Check if cursors are in the same line
// Check if cursor stayed on the line.
if (oldPos.rows === newPos.rows) {
const diffCursor = this.cursor - oldcursor;
let diffWidth;
if (diffCursor < 0) {
diffWidth = -getStringWidth(
this.line.substring(this.cursor, oldcursor)
);
} else if (diffCursor > 0) {
diffWidth = getStringWidth(
this.line.substring(this.cursor, oldcursor)
);
}
const diffWidth = newPos.cols - oldPos.cols;
moveCursor(this.output, diffWidth, 0);
this.prevRows = newPos.rows;
} else {
this._refreshLine();
}
6 changes: 3 additions & 3 deletions test/parallel/test-repl-preview.js
Original file line number Diff line number Diff line change
@@ -93,9 +93,9 @@ async function tests(options) {
'\x1B[33mtrue\x1B[39m',
'\x1B[1G\x1B[0Jrepl > \x1B[8G'],
[' \t { a: true};', [2, 5], '\x1B[33mtrue\x1B[39m',
' \t { a: tru\x1B[90me\x1B[39m\x1B[19G\x1B[0Ke}',
'\x1B[90m{ a: true }\x1B[39m\x1B[8C\x1B[1A\x1B[1B\x1B[2K\x1B[1A;',
'\x1B[90mtrue\x1B[39m\x1B[16C\x1B[1A\x1B[1B\x1B[2K\x1B[1A\r',
' \t { a: tru\x1B[90me\x1B[39m\x1B[26G\x1B[0Ke}',
'\x1B[90m{ a: true }\x1B[39m\x1B[16C\x1B[1A\x1B[1B\x1B[2K\x1B[1A;',
'\x1B[90mtrue\x1B[39m\x1B[24C\x1B[1A\x1B[1B\x1B[2K\x1B[1A\r',
'\x1B[33mtrue\x1B[39m',
'\x1B[1G\x1B[0Jrepl > \x1B[8G']
];

0 comments on commit 50a16ed

Please sign in to comment.