New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: call asm_to_inline_asm, correct lib paths and remove masm #10

Merged

targos merged 2 commits into targos:clang-cl from lemire:clang-cl-embed-asm

Jan 4, 2024

lemire commented Jan 3, 2024

With this PR, I am able to get a clean build with ClangCL. The PR does three things:

Instead of trying to compile the snapshot asm directly, it embeds it in cc file using tools/snapshot/asm_to_inline_asm.py. It is how v8 does it.
Visual Studio could not find some libraries with ClangCL when passing /WHOLEARCHIVE:nameoflib so we correct the problem by providing the full path.
We remove the masm builds as they are no longer necessary.

lemire added 2 commits

January 3, 2024 10:31


          fix: embed snapshot asm into a source file like v8 does

4c784d1


          fix: lib paths and remove unneeded masm

fcb20c9

lemire mentioned this pull request

build: enable Clang-cl Windows builds nodejs/node#35433

Closed

targos merged commit 12c055a into targos:clang-cl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet