Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(202-tariscript): add missing OP_CHECKMULTISIG/VERIFY and update error codes #15

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Sep 28, 2022

Description

  • Adds docs for CheckMultiSig(Msg) and CheckMultiSigVerify(Msg)
  • Update error table to reflect implementation

Motivation and Context

Reconcile implementation and RFC differences

stringhandler pushed a commit to tari-project/tari that referenced this pull request Oct 3, 2022
Description
---
- Adds ToRistrettoPoint opcodes
- Added scalar stack item

Motivation and Context
---
As per RFC-202
Ref tari-project/rfcs#15
Ref #4742

How Has This Been Tested?
---
Additional unit tests + tests updated
SWvheerden
SWvheerden previously approved these changes Oct 6, 2022
Copy link
Contributor

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CjS77
Copy link
Contributor

CjS77 commented Oct 11, 2022

+1. Just add a Change Log section please

@CjS77
Copy link
Contributor

CjS77 commented Oct 13, 2022

Why is this controversial @stringhandler?

@CjS77 CjS77 merged commit 261c3b1 into tari-project:main Oct 13, 2022
CjS77 pushed a commit that referenced this pull request Nov 1, 2022
…rror codes (#15)

* fix(202-tariscript): add missing OP_CHECKMULTISIG/VERIFY and update error codes

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants