feat!: new notify usage #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/server/p2p/network.rs
Outdated
| }, | ||
| }; | ||
| let notify = NotifyNewTipBlock::new(local_peer_id, tip_blocks); | ||
| let _unused = notify_channel.send(notify); |
There was a problem hiding this comment.
This feels wrong here. We will publish many newtips, instead of only the miner who sends it at the moment
src/sharechain/in_memory.rs
Outdated
| @@ -652,6 +637,24 @@ impl ShareChain for InMemoryShareChain { | |||
| .build()?) | |||
| } | |||
|
|
|||
| async fn get_tip_and_uncle_blocks(&self) -> Result<Vec<Arc<P2Block>>, ShareChainError> { | |||
There was a problem hiding this comment.
This was previously unused. Is it used now?
src/sharechain/p2chain_level.rs
Outdated
| @@ -66,8 +66,8 @@ impl P2ChainLevel { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| pub fn block_in_main_chain(&self) -> Option<&Arc<P2Block>> { | |||
| self.blocks.get(&self.chain_block) | |||
| pub fn block_in_main_chain(&self) -> Option<Arc<P2Block>> { | |||
There was a problem hiding this comment.
I'm not sure I like this. Perhaps get_block_in_main_chain
SWvheerden
force-pushed
the
sw_change_notify
branch
from
4126c21 to
9ce8f8c
Compare
|
replaced by #224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes how new tip notify works.
Blocks will only propagate new_tip_notify if it accepts the new tip
Sent out new tip notify if you did a catchup sync and got a new tip