fix(engine): prevent creation of mismatched resource type bucket #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
approved these changes
Feb 27, 2024
Merged
via the queue into
tari-project:development
with commit Feb 27, 2024
2c91463
11 checks passed
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Feb 27, 2024
* development: fix(engine): prevent creation of mismatched resource type bucket (tari-project#940) chore: update to latest feature-dan2 (tari-project#937) feat!: optional versions in transaction inputs (tari-project#922) feat: add tari-generate (tari-project#941)
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Feb 27, 2024
* development: feat(walletd/js/client): use abstract transport to allow for WebRTC transport (tari-project#943) fix(engine): prevent creation of mismatched resource type bucket (tari-project#940) chore: update to latest feature-dan2 (tari-project#937) feat!: optional versions in transaction inputs (tari-project#922) feat: add tari-generate (tari-project#941)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix(engine): add resource type check when processing mint args
fix(engine): improve error for resource type mismatch
fix(engine): erroneous dangling resource error when creating an empty vault from a resource
test(engine): add previously failing test for minting a different resource type
Motivation and Context
By specifying mismatching MintArgs you were previously able to create a bucket for a resource type that did not match the resource being operated on.
This test exposed another bug which is also tested in the new test. This occurs when you create an empty vault from a new resource, the engine fails with a dangling resource error because it does not recognise that the new empty resource is contained within the new empty vault.
How Has This Been Tested?
A new failing test, that passes after changes
What process can a PR reviewer use to test or verify this change?
Run engine tests
Breaking Changes