Skip to content

Commit

Permalink
fix(ci): update GHA set-output plus dependabot schedule for GHA (#4857)
Browse files Browse the repository at this point in the history
Description
GHA have update environment variable storage

Motivation and Context
Remove CI/build warnings

How Has This Been Tested?
Builds in local fork
  • Loading branch information
leet4tari authored Oct 27, 2022
1 parent 2d90e91 commit f978507
Show file tree
Hide file tree
Showing 8 changed files with 40 additions and 33 deletions.
8 changes: 8 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
version: 2
updates:
# Maintain dependencies for GitHub Actions
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"
10 changes: 5 additions & 5 deletions .github/workflows/auto_labels.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
on:
'on':
workflow_run:
workflows:
- "Clippy check"
Expand All @@ -12,15 +12,15 @@ jobs:
if: ${{ github.event.workflow_run.conclusion == 'success' }}
steps:
- name: Download workflow artifact
uses: dawidd6/action-download-artifact@v2.11.0
uses: dawidd6/action-download-artifact@v2.24.0
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
workflow: CI
run_id: ${{ github.event.workflow_run.id }}

- name: Read PR number
id: pr_num
uses: juliangruber/read-file-action@v1.0.0
uses: juliangruber/read-file-action@v1.1.6
with:
path: ./pr_num.txt

Expand All @@ -36,15 +36,15 @@ jobs:
if: ${{ github.event.workflow_run.conclusion == 'failure' }}
steps:
- name: Download workflow artifact
uses: dawidd6/action-download-artifact@v2.11.0
uses: dawidd6/action-download-artifact@v2.24.0
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
workflow: CI
run_id: ${{ github.event.workflow_run.id }}

- name: Read PR number
id: pr_num
uses: juliangruber/read-file-action@v1.0.0
uses: juliangruber/read-file-action@v1.1.6
with:
path: ./pr_num.txt

Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/base_node_binaries.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: Build Matrix of Binaries

on:
'on':
push:
tags:
- "v[0-9]+.[0-9]+.[0-9]+"
Expand Down Expand Up @@ -49,7 +49,7 @@ jobs:
matrix=$(echo ${matrix_selection} | jq -s -c '{"builds": .}')
echo $matrix
echo $matrix | jq .
echo "::set-output name=matrix::$matrix"
echo "matrix=${matrix}" >> $GITHUB_OUTPUT
matrix-check:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -308,7 +308,7 @@ jobs:
- name: Artifact upload for macOS pkg
if: startsWith(runner.os,'macOS')
continue-on-error: true
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: ${{ env.TBN_FILENAME }}-${{ matrix.builds.name }}-${{ env.VERSION }}.pkg
path: "${{ env.distDirPKG }}/${{ env.TBN_FILENAME }}-${{ matrix.builds.name }}-${{ env.VERSION }}*.pkg"
Expand All @@ -323,7 +323,7 @@ jobs:
"%programfiles(x86)%\Inno Setup 6\iscc.exe" "/DMyAppVersion=${{ env.VERSION }}-${{ env.VSHA_SHORT }}-release" "/DTariSuitePath=${{ github.workspace }}${{ env.TBN_DIST }}" "windows_inno_installer.iss"
- name: Artifact upload for Windows installer
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
if: startsWith(runner.os,'Windows')
with:
name: "tari_windows_installer"
Expand All @@ -348,13 +348,13 @@ jobs:
fi
- name: Artifact upload for Archive
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: ${{ env.TBN_FILENAME }}_archive-${{ matrix.builds.name }}
path: "${{ github.workspace }}${{ env.TBN_DIST }}/${{ env.BINFILE }}.zip*"

- name: Artifact upload for Miner
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: tari_miner-${{ matrix.builds.name }}
path: "${{ github.workspace }}${{ env.TBN_DIST }}/tari_miner${{ env.TBN_EXT}}"
Expand Down Expand Up @@ -427,7 +427,7 @@ jobs:
if: ${{ startsWith(github.ref, 'refs/tags/v') }}
steps:
- name: Download binaries
uses: actions/download-artifact@v2
uses: actions/download-artifact@v3
- name: Create release
uses: ncipollo/release-action@v1
with:
Expand Down
24 changes: 12 additions & 12 deletions .github/workflows/build_dockers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,28 +70,28 @@ jobs:
echo "SHA short - ${VSHA_SHORT}"
echo "VSHA_SHORT=${VSHA_SHORT}" >> $GITHUB_ENV
TOOLCHAIN=${{ github.event.inputs.toolchain }}
echo "::set-output name=toolchain::${TOOLCHAIN:-${{ env.toolchain_default }}}"
echo "toolchain=${TOOLCHAIN:-${{ env.toolchain_default }}}" >> $GITHUB_OUTPUT
if [[ "${{ github.ref }}" =~ ^refs/tags/v* ]] && [ "${{ github.event_name }}" != "workflow_dispatch" ] ; then
echo "Tagged Build - Build everything"
VERSION="${{ github.ref_name }}_$(date -u '+%Y%m%d')_${VSHA_SHORT}"
echo "Version used - ${VERSION}"
echo "::set-output name=platforms::linux/arm64, linux/amd64"
echo "::set-output name=version::${VERSION}"
echo "::set-output name=tag_alias::latest"
echo "::set-output name=build_items::all"
echo "platforms=linux/arm64, linux/amd64" >> $GITHUB_OUTPUT
echo "version=${VERSION}" >> $GITHUB_OUTPUT
echo "tag_alias=latest" >> $GITHUB_OUTPUT
echo "build_items=all" >> $GITHUB_OUTPUT
fi
if [ "${{ github.event_name }}" == "workflow_dispatch" ] ; then
echo "Manual Build - selective"
echo "::set-output name=platforms::${{ github.event.inputs.platforms }}"
echo "::set-output name=version::${{ github.event.inputs.version }}"
echo "::set-output name=tag_alias::${{ github.event.inputs.tag_alias }}"
echo "::set-output name=build_items::${{ github.event.inputs.build_items }}"
echo "platforms=${{ github.event.inputs.platforms }}" >> $GITHUB_OUTPUT
echo "version=${{ github.event.inputs.version }}" >> $GITHUB_OUTPUT
echo "tag_alias=${{ github.event.inputs.tag_alias }}" >> $GITHUB_OUTPUT
echo "build_items=${{ github.event.inputs.build_items }}" >> $GITHUB_OUTPUT
fi
if [ "${{ github.event_name }}" == "schedule" ] && [ "${{ github.event.schedule }}" == "05 00 * * *" ] ; then
echo "Daily Build - limited"
echo "::set-output name=platforms::linux/amd64"
echo "::set-output name=tag_alias::latest-daily"
echo "::set-output name=build_items::tari_all"
echo "platforms=linux/amd64" >> $GITHUB_OUTPUT
echo "tag_alias=latest-daily" >> $GITHUB_OUTPUT
echo "build_items=tari_all" >> $GITHUB_OUTPUT
fi
builds_run:
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/build_dockers_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,7 @@ jobs:
echo $matrix
echo $matrix | jq .
echo "::set-output name=matrix::$matrix"
#echo "matrix=${matrix}" >> $GITHUB_ENV
echo "matrix=${matrix}" >> $GITHUB_OUTPUT
docker_build:
name: Docker building ${{ matrix.builds.image_name }}
Expand Down Expand Up @@ -160,7 +159,7 @@ jobs:
fi
- name: Login to Docker Image Provider
uses: docker/login-action@v1
uses: docker/login-action@v2
with:
registry: ${{ secrets.DOCKER_PROVIDER }}
username: ${{ secrets.DOCKER_USERNAME }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build_libwallets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ jobs:
id: envs_setup
run: |
TOOLCHAIN=${{ github.event.inputs.toolchain }}
echo "::set-output name=toolchain::${TOOLCHAIN:-${{ env.toolchain_default }}}"
echo "toolchain=${TOOLCHAIN:-${{ env.toolchain_default }}}" >> $GITHUB_OUTPUT
BUILD_ANDROID=${{ github.event.inputs.build_android }}
echo "::set-output name=build_android::${BUILD_ANDROID:-true}"
echo "build_android=${BUILD_ANDROID:-true}" >> $GITHUB_OUTPUT
BUILD_IOS=${{ github.event.inputs.build_ios }}
echo "::set-output name=build_ios::${BUILD_IOS:-true}"
echo "build_ios=${BUILD_IOS:-true}" >> $GITHUB_OUTPUT
builds_run:
needs: builds_envs_setup
Expand Down Expand Up @@ -89,7 +89,7 @@ jobs:
if: ${{ startsWith(github.ref, 'refs/tags/v') }}
steps:
- name: Download binaries
uses: actions/download-artifact@v2
uses: actions/download-artifact@v3
- name: Create release
uses: ncipollo/release-action@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ jobs:
run: echo $PR_NUM > pr_num.txt

- name: Upload the PR number
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: pr_num
path: ./pr_num.txt
2 changes: 1 addition & 1 deletion .github/workflows/pr_title.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# See https://www.conventionalcommits.org/en/v1.0.0/ for more information
name: PR

on:
'on':
pull_request:
types:
- opened
Expand Down

0 comments on commit f978507

Please sign in to comment.