fix last test, add comment

tari-project · Feb 21, 2023 · fb95396 · fb95396
1 parent 7a87da3
commit fb95396
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 11 deletions.
diff --git a/base_layer/core/src/chain_storage/tests/blockchain_database.rs b/base_layer/core/src/chain_storage/tests/blockchain_database.rs
@@ -583,6 +583,7 @@ mod validator_node_merkle_root {
     use super::*;
     use crate::{
         transactions::transaction_components::{OutputFeatures, ValidatorNodeSignature},
+        ValidatorNodeBMT,
         ValidatorNodeMmr,
     };
 
@@ -618,18 +619,13 @@ mod validator_node_merkle_root {
             .unwrap()
             .unwrap();
 
-        let mut vn_mmr = ValidatorNodeMmr::new(Vec::new());
-        vn_mmr
-            .push(
-                Blake256::new()
-                    .chain(public_key.as_bytes())
-                    .chain(shard_key.as_slice())
-                    .finalize()
-                    .to_vec(),
-            )
-            .unwrap();
+        let vn_bmt = ValidatorNodeBMT::create(vec![Blake256::new()
+            .chain(public_key.as_bytes())
+            .chain(shard_key.as_slice())
+            .finalize()
+            .to_vec()]);
 
         let tip = db.fetch_tip_header().unwrap();
-        assert_eq!(tip.header().validator_node_mr, vn_mmr.get_merkle_root().unwrap());
+        assert_eq!(tip.header().validator_node_mr, vn_bmt.get_merkle_root());
     }
 }
diff --git a/base_layer/mmr/src/balanced_binary_merkle_tree.rs b/base_layer/mmr/src/balanced_binary_merkle_tree.rs
@@ -45,6 +45,7 @@ pub struct BalancedBinaryMerkleTree<D> {
 impl<D> BalancedBinaryMerkleTree<D>
 where D: Digest + DomainDigest
 {
+    // There is no push method for this tree. This tree is created at once and no modifications are allowed.
     pub fn create(leaves: Vec<Hash>) -> Self {
         let leaves_cnt = leaves.len();
         if leaves_cnt == 0 {