-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add sanity checks to prepare_new_block #3448
fix: add sanity checks to prepare_new_block #3448
Conversation
46c40c4
to
b22c583
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the sanity checks goes against a current config option/feature. We need to remove one of the two.
* development: chore: improve cucumber tags and run time speed (tari-project#3439)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* development: fix: add display_currency_decimal method (tari-project#3445) fix: add sanity checks to prepare_new_block (tari-project#3448) test: profile wallet sqlite database operations (tari-project#3451) test: create cucumber test directory if necessary (tari-project#3452) chore: improve cucumber tags and run time speed (tari-project#3439)
Description
prepare_new_block
prepare_new_block
get_new_block
GRPC call returns invalid argument error if invalid arguments are passed toprepare_new_block
Motivation and Context
Possible panic observed in cucumber test is prevented
How Has This Been Tested?
New unit tests + existing tests