chore: improve cucumber tags and run time speed #3439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
changed the title
SWvheerden
force-pushed
the
sw_improve_cucumber_tags
branch
from
ee18d93 to
301d806
Compare
philipr-za
reviewed
Oct 11, 2021
SWvheerden
force-pushed
the
sw_improve_cucumber_tags
branch
2 times, most recently
from
14bdb2f to
30e9dee
Compare
|
Not sure what’s gone wrong with the grpc client now |
SWvheerden
force-pushed
the
sw_improve_cucumber_tags
branch
3 times, most recently
from
c67ac04 to
e9f90be
Compare
Add flaky and broken tags update readme shorten tests and move more to long-running
SWvheerden
force-pushed
the
sw_improve_cucumber_tags
branch
from
e9f90be to
d5e6279
Compare
| @@ -1,13 +1,14 @@ | |||
| @wallet | |||
| @wallet-query | |||
There was a problem hiding this comment.
Suggested change
| @wallet-query | |
| @wallet-query @wallet |
| @@ -51,7 +48,7 @@ Feature: Wallet Monitoring | |||
| Then all COINBASE transactions for wallet WALLET_A1 and wallet WALLET_B1 have consistent but opposing validity | |||
|
|
|||
| # 18+ mins on circle ci | |||
| @long-running | |||
| @long-running @wallet | |||
There was a problem hiding this comment.
You can just put this tag at the top of the file
There was a problem hiding this comment.
Moved all '@wallet' and all '@base-node' tags where I could to the top
SWvheerden
force-pushed
the
sw_improve_cucumber_tags
branch
from
81b8304 to
4e78ef1
Compare
SWvheerden
force-pushed
the
sw_improve_cucumber_tags
branch
from
4e78ef1 to
9972884
Compare
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 13, 2021
* development: chore: improve cucumber tags and run time speed (tari-project#3439)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 15, 2021
* development: fix: add display_currency_decimal method (tari-project#3445) fix: add sanity checks to prepare_new_block (tari-project#3448) test: profile wallet sqlite database operations (tari-project#3451) test: create cucumber test directory if necessary (tari-project#3452) chore: improve cucumber tags and run time speed (tari-project#3439)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the run time of certain tests to remove
waitsand make sure they have async functions to retest waitable events.It adds a
@base-nodetag to all base node tests.It adds a
@wallettag to all wallet tests.It adds
@tags to all feature files.Its adds and remove
@criticaltags to all required tests, adding where critical functionality is not tested and removing where it is double tested and or not critical to core functionality.Motivation and Context
Made sure we can run all tests as short as possible. Tests are grouped with the following tags:
@base-nodewhich can be used to run tests if verification of code base node functionality is desired@walletwhich can be used to run tests if verification of code wallet functionality is desired@criticalif a short test of all core functionality is desired.@long-runningif really detailed long-running tests are desired. Can take hours.Tests without a
@criticaland@long-runningare tests that are required for passing CI, but will take longer to run.Running test with
--tags @base-node AND @criticalor--tags @wallet AND @criticalcompletes it run time below 10 minutes.