Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tari Script should use Varints instead of u64's #4108

Closed
stringhandler opened this issue May 17, 2022 · 0 comments
Closed

Tari Script should use Varints instead of u64's #4108

stringhandler opened this issue May 17, 2022 · 0 comments
Assignees
@Cifko

Comments

@stringhandler
Copy link
Collaborator

For example, CHECK_HEIGHT takes in a u64 which for the most part will be padded zeroes. It should use VarInt when serializing and deserializing
@Cifko Cifko self-assigned this Aug 12, 2022
@Cifko Cifko mentioned this issue Aug 12, 2022
Merged
@SWvheerden SWvheerden moved this to In Progress in Tari Esme Testnet Aug 15, 2022
@SWvheerden SWvheerden moved this from In Progress to In Review in Tari Esme Testnet Aug 16, 2022
aviator-app bot pushed a commit that referenced this issue Aug 17, 2022
@Cifko
feat(tariscript)!: use varints in tari script (de)serialization (#4460)
a0403e5 
Description
---
Use varint for op codes that use 64bit numbers but in general will be low.

Motivation and Context
---
#4108

How Has This Been Tested?
---
Unit tests.
Repository owner moved this from In Review to Done in Tari Esme Testnet Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cifko Cifko

Labels
None yet
Projects
Tari Esme Testnet
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SWvheerden @stringhandler @Cifko