Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/covenants)!: update covenants to support OutputType enum #4472

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Aug 15, 2022

Description

  • adds new output type arg type
  • adds field_eq support for filtering by output type
  • adds new test to check this case

Motivation and Context

  • Covenants were still using the old output_flags field name
  • an OutputType argument literal was needed as filters like field_eq were not able to compare OutputTypes

The following syntax is supported:
field_eq(@field::features_output_type, @output_type(Burn))

How Has This Been Tested?

Additional unit tests

@sdbondi sdbondi marked this pull request as ready for review August 15, 2022 11:19
@sdbondi sdbondi changed the title fix(core/covenants): update covenants to support OutputType enum fix(core/covenants)!: update covenants to support OutputType enum Aug 15, 2022
SWvheerden
SWvheerden previously approved these changes Aug 16, 2022
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…ld-selector

* development:
  fix: wrong ban reason (tari-project#4461)
  fix broken critical cucumber test (tari-project#4458)
  chore: remove Defunct L2 code (tari-project#4463)
  fix(ci): binary builds - remove tari_collectibles and lib deps for linux  (tari-project#4454)
  feat(docker) :build tari docker images for launchpad (tari-project#4476)
  fix: fix transaction output hashing (tari-project#4483)
  chore: remove broken tag from working tests (tari-project#4471)
  fix: wallet always scan interactive payments (see tari-project#4452) (tari-project#4464)
  feat: remove total_txs and rename total_weight in mempool (tari-project#4474)
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stringhandler stringhandler merged commit e21dfdb into tari-project:development Aug 18, 2022
@sdbondi sdbondi deleted the core-covenants-update-output-type-field-selector branch August 18, 2022 09:48
sdbondi added a commit to sdbondi/tari that referenced this pull request Aug 22, 2022
* development:
  feat!: add hashing API use to base layer (see issue tari-project#4394) (tari-project#4447)
  feat(wallet): adds --stealth-one-sided flag to make-it-rain (tari-project#4508)
  fix!: change monero consensus encoding an update for hardfork v15 (tari-project#4492)
  fix(core/covenants)!: update covenants to support OutputType enum (tari-project#4472)
  feat(core)!: restrict output types to only those permitted by consensus (tari-project#4467)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants