-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add hashing API use to base layer (see issue #4394) #4447
feat!: add hashing API use to base layer (see issue #4394) #4447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, but I think we can simplify the domain separated hashing a bit, as suggested. The suggestion can be applied throughout.
Remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* development: feat!: add hashing API use to base layer (see issue tari-project#4394) (tari-project#4447) feat(wallet): adds --stealth-one-sided flag to make-it-rain (tari-project#4508) fix!: change monero consensus encoding an update for hardfork v15 (tari-project#4492) fix(core/covenants)!: update covenants to support OutputType enum (tari-project#4472) feat(core)!: restrict output types to only those permitted by consensus (tari-project#4467)
Description
Refactor base_layer repo to use the hashing API.
Motivation and Context
Fixes #4394.
How Has This Been Tested?
Unit tests