Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add hashing API use to base layer (see issue #4394) #4447

Merged

Conversation

jorgeantonio21
Copy link
Contributor

@jorgeantonio21 jorgeantonio21 commented Aug 11, 2022

Description

Refactor base_layer repo to use the hashing API.

Motivation and Context

Fixes #4394.

How Has This Been Tested?

Unit tests

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but I think we can simplify the domain separated hashing a bit, as suggested. The suggestion can be applied throughout.

base_layer/common_types/src/types/mod.rs Outdated Show resolved Hide resolved
base_layer/common_types/src/types/bullet_rangeproofs.rs Outdated Show resolved Hide resolved
base_layer/common_types/src/types/bullet_rangeproofs.rs Outdated Show resolved Hide resolved
base_layer/core/src/chain_storage/lmdb_db/mod.rs Outdated Show resolved Hide resolved
base_layer/core/src/chain_storage/lmdb_db/mod.rs Outdated Show resolved Hide resolved
base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs Outdated Show resolved Hide resolved
base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs Outdated Show resolved Hide resolved
@jorgeantonio21
Copy link
Contributor Author

Remove @dan cucumber tests from WalletCli.feature, see PR #4490.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stringhandler stringhandler merged commit f9af875 into tari-project:development Aug 19, 2022
sdbondi added a commit to sdbondi/tari that referenced this pull request Aug 22, 2022
* development:
  feat!: add hashing API use to base layer (see issue tari-project#4394) (tari-project#4447)
  feat(wallet): adds --stealth-one-sided flag to make-it-rain (tari-project#4508)
  fix!: change monero consensus encoding an update for hardfork v15 (tari-project#4492)
  fix(core/covenants)!: update covenants to support OutputType enum (tari-project#4472)
  feat(core)!: restrict output types to only those permitted by consensus (tari-project#4467)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement tari_crypto hashing API: base_layer core
5 participants