feat: trigger mempool sync on lag #4730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
reviewed
Sep 23, 2022
SWvheerden
force-pushed
the
sw_mempool_sync
branch
3 times, most recently
from
fd016f3 to
75ada73
Compare
stringhandler
previously approved these changes
Sep 26, 2022
Co-authored-by: Stan Bondi <sdbondi@users.noreply.github.com>
SWvheerden
force-pushed
the
sw_mempool_sync
branch
from
de7245d to
ae5fba2
Compare
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Sep 29, 2022
…re-dan * network-dependent-grpc-ports: feat: different default grpc ports for different networks fix(clients): fix tari nodejs client proto paths (tari-project#4743) chore: disallow onion v2 (tari-project#4745) feat: change priority in mempool to take into account age (tari-project#4737) feat: trigger mempool sync on lag (tari-project#4730) fix(core): use compact inputs for block propagation (tari-project#4714) ci: deny dbg macro (tari-project#4740)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 3, 2022
* development: v0.38.5 feat: different default grpc ports for different networks (tari-project#4755) fix(core): broken doctests (tari-project#4763) ci: fix coverage job ci: run coverage on prs (tari-project#4738) fix(comms): fixes edge case where online status event does not get published (tari-project#4756) fix(dht/encryption): greatly reduce heap allocations for encrypted messaging (tari-project#4753) docs: explain the emission curve parameters (tari-project#4750) fix(comms/peer_manager): add migration to remove onionv2 addresses (tari-project#4748) fix(ci): add cargo cache, reduce Ubuntu dependencies and action on pull_request (tari-project#4757) feat(tariscript): adds ToRistrettoPoint op-code (tari-project#4749) fix: cli wallet cucumber (tari-project#4739) fix(clients): fix tari nodejs client proto paths (tari-project#4743) chore: disallow onion v2 (tari-project#4745) feat: change priority in mempool to take into account age (tari-project#4737) feat: trigger mempool sync on lag (tari-project#4730) fix(core): use compact inputs for block propagation (tari-project#4714) ci: deny dbg macro (tari-project#4740)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds in the ability to retrigger the mempool sync if a larger re_org or block sync occurred.
Motivation and Context
As of #4706 the mempool will now properly handle re-orgs and block syncs.
But when the base_node is not at the "correct" tip its mempool will reject all invalid transactions. In order to get those transactions back, we need to trigger a mempool sync.
This adds in a new config setting to control the maximum number of blocks the base_node added during a reorg or sync before it starts a sync process.
The assumption is that in most cases, the blocks removed will be less or the same as the blocks added, so we only need to look at the blocks added.
Open Questions
Do we just sync to one peer, or do we sync to
initial_sync_num_peerspeer?Prerequisite
Requires: #4706