Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: different default grpc ports for different networks #4755

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Sep 29, 2022

Description

Use different default GRPC ports for different networks

  • BaseNode
    • Dibbler: 18122
    • Esmeralda: 18142
    • Igor: 18152
  • ConsoleWallet
    • Dibbler: 18123
    • Esmeralda: 18143
    • Igor: 18153

Motivation and Context

More explicit separation of networks allowing GRPC to work when running two different networks on the same machine.

How Has This Been Tested?

Manually

@sdbondi sdbondi force-pushed the network-dependent-grpc-ports branch from 7722304 to d378aaf Compare September 29, 2022 10:36
@sdbondi sdbondi force-pushed the network-dependent-grpc-ports branch from d378aaf to 6005a66 Compare September 29, 2022 10:52
CjS77
CjS77 previously approved these changes Sep 29, 2022
Copy link
Collaborator

@CjS77 CjS77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We need to add grpc_enabled back to the base node as there is currently no way of turning GRPC off

@sdbondi
Copy link
Member Author

sdbondi commented Oct 3, 2022

💯 - Done

@stringhandler stringhandler merged commit 933126e into tari-project:development Oct 3, 2022
@sdbondi sdbondi deleted the network-dependent-grpc-ports branch October 3, 2022 13:25
sdbondi added a commit to sdbondi/tari that referenced this pull request Oct 3, 2022
* development:
  v0.38.5
  feat: different default grpc ports for different networks (tari-project#4755)
  fix(core): broken doctests (tari-project#4763)
  ci: fix coverage job
  ci: run coverage on prs (tari-project#4738)
  fix(comms): fixes edge case where online status event does not get published (tari-project#4756)
  fix(dht/encryption): greatly reduce heap allocations for encrypted messaging (tari-project#4753)
  docs: explain the emission curve parameters (tari-project#4750)
  fix(comms/peer_manager): add migration to remove onionv2 addresses (tari-project#4748)
  fix(ci): add cargo cache, reduce Ubuntu dependencies and action on pull_request (tari-project#4757)
  feat(tariscript): adds ToRistrettoPoint op-code (tari-project#4749)
  fix: cli wallet cucumber (tari-project#4739)
  fix(clients): fix tari nodejs client proto paths (tari-project#4743)
  chore: disallow onion v2 (tari-project#4745)
  feat: change priority in mempool to take into account age (tari-project#4737)
  feat: trigger mempool sync on lag (tari-project#4730)
  fix(core): use compact inputs for block propagation (tari-project#4714)
  ci: deny dbg macro (tari-project#4740)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants