fix: support arbitrary range proof batching #5049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agubarev
pushed a commit
to agubarev/tari
that referenced
this pull request
Dec 14, 2022
* Support arbitrary range proof batching * Empty batches are valid * Formatting
stringhandler
pushed a commit
that referenced
this pull request
Jan 4, 2023
Description --- Updates `tari-crypto` dependencies to use range proof batch splitting. Motivation and Context --- An [earlier PR](#5049) removed an unnecessary restriction on range proof batch splitting. Recent `bulletproofs-plus` work [updates range proof batching](tari-project/bulletproofs-plus#22) to split large batches for performance reasons, and also updates the verification API for clarity. A [corresponding PR](tari-project/tari-crypto#160) in `tari-crypto` uses this new API, but does not change its own external range proof verification API. This PR updates `tari-crypto` dependencies to take advantage of this new functionality. How Has This Been Tested? --- Existing tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes an unnecessary power-of-two batch decomposition for range proof batch verification.
Closes issue #5048.
Motivation and Context
Range proofs can be verified in batches for significant performance improvements. However, they are currently verified only in batches with power-of-two sizes. This may be due to a misunderstanding between aggregation (which requires such a restriction) and batching (which does not).
This work removes the restriction and provides the range proof verifier with all proofs in a batch.
Because of performance limitations, it may be useful to impose a size restriction in the verifier, where a very large batch is split into smaller batches.
How Has This Been Tested?
Existing tests pass.