feat!: replace utxo MMR with SMT #5854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
the
CR-too_long
SWvheerden
force-pushed
the
feature-smt
branch
from
7a0be40 to
24eaa10
Compare
ghpbot-tari-project
added
P-acks_required
SWvheerden
force-pushed
the
feature-smt
branch
from
a4fabcb to
6adc016
Compare
SWvheerden
changed the title
SWvheerden
force-pushed
the
feature-smt
branch
2 times, most recently
from
5e5955b to
ccf9fd6
Compare
Description --- This replaces the UTXO MMR and the Roaring bitmap with a single SMT. Motivation and Context --- See: tari-project/rfcs#105 as to why the SMT is the better choice. How Has This Been Tested? --- Manual
Description --- Fixes rewind/reorg for sparse merkle tree
Description --- Fixes horizon sync by selecting the correct tip smt and sending the correct starting header Motivation and Context --- Horizon sync starts at height 1 technically as the node already has the genesis block. How Has This Been Tested? --- Manual
Description --- Fixes a resize issue with horizon sync mode Motivation and Context --- Lmdb only resizes on transactions, and not pure table changes in our code, this changes the tip smt to always use the transactions, as this call might be large. How Has This Been Tested? --- manual
Description --- Updates the SMT branch with code review --------- Co-authored-by: Hansie Odendaal <39146854+hansieodendaal@users.noreply.github.com>
Description --- final hazop code review for SMT
SWvheerden
force-pushed
the
feature-smt
branch
from
ccf9fd6 to
dd29cfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces the UTXO MMR and the Roaring bitmap with a single SMT.
Motivation and Context
See: tari-project/rfcs#105 as to why the SMT is the better choice.
CRoaring, the library that is used by Tari for the roaring bitmap also has a few security issues such as panicking on certain random inputs.
How Has This Been Tested?
Manual, and unit tests
What process can a PR reviewer use to test or verify this change?