Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace mmr + bitmap with smt #5822

Merged
merged 9 commits into from
Oct 12, 2023
Merged

feat: replace mmr + bitmap with smt #5822

merged 9 commits into from
Oct 12, 2023

Conversation

SWvheerden
Copy link
Collaborator

@SWvheerden SWvheerden commented Sep 28, 2023 •
edited
Loading

Description

This replaces the UTXO MMR and the Roaring bitmap with a single SMT.

Motivation and Context

See: tari-project/rfcs#105 as to why the SMT is the better choice.

How Has This Been Tested?

Manual

@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited
Loading

Test Results (Integration tests)

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 9c64b58.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 28, 2023
@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited
Loading

Test Results (CI)

156 tests   155 ✔️  4m 4s ⏱️
  13 suites      0 💤
    1 files        1 ❌

For more details on these failures, see this check.

Results for commit 5e21f95.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added the CR-too_long Changes Requested - Your PR is too long label Oct 6, 2023
@SWvheerden SWvheerden changed the base branch from development to feature-smt October 9, 2023 11:51
@SWvheerden SWvheerden changed the title [WIP] feat: replace mmr + bitmap with smt feat: replace mmr + bitmap with smt Oct 9, 2023
@ghpbot-tari-project ghpbot-tari-project added P-conflicts Process - The PR has merge conflicts that need to be resolved CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. and removed P-conflicts Process - The PR has merge conflicts that need to be resolved labels Oct 9, 2023
@SWvheerden
wip
a3e3d89 
wip sync done

some more code

deleted some stuff

wip

more changes

wip code

wip

more wip
@SWvheerden
wip
bbb895b
@SWvheerden
working build
306a7a3
@SWvheerden
wallet changes
680c4c0
@SWvheerden
wip
fbd7aaf
@SWvheerden
some mining
743ae5c
@SWvheerden
fix some tests
a8e5ecd
@SWvheerden
some fixes
edb84ff
@stringhandler stringhandler merged commit 50238f2 into tari-project:feature-smt Oct 12, 2023
5 of 9 checks passed
SWvheerden added a commit that referenced this pull request Oct 25, 2023
@SWvheerden
feat: replace mmr + bitmap with smt (#5822)
d5149e2 
Description
---
This replaces the UTXO MMR and the Roaring bitmap with a single SMT. 

Motivation and Context
---
See: tari-project/rfcs#105 as to why the SMT is
the better choice.

How Has This Been Tested?
---
Manual
SWvheerden added a commit that referenced this pull request Nov 1, 2023
@SWvheerden
feat: replace mmr + bitmap with smt (#5822)
d0226c8 
Description
---
This replaces the UTXO MMR and the Roaring bitmap with a single SMT. 

Motivation and Context
---
See: tari-project/rfcs#105 as to why the SMT is
the better choice.

How Has This Been Tested?
---
Manual
SWvheerden added a commit that referenced this pull request Nov 2, 2023
@SWvheerden
feat: replace mmr + bitmap with smt (#5822)
fadd622 
Description
---
This replaces the UTXO MMR and the Roaring bitmap with a single SMT. 

Motivation and Context
---
See: tari-project/rfcs#105 as to why the SMT is
the better choice.

How Has This Been Tested?
---
Manual
SWvheerden added a commit that referenced this pull request Nov 2, 2023
@SWvheerden
feat: replace mmr + bitmap with smt (#5822)
34dc6c6 
Description
---
This replaces the UTXO MMR and the Roaring bitmap with a single SMT. 

Motivation and Context
---
See: tari-project/rfcs#105 as to why the SMT is
the better choice.

How Has This Been Tested?
---
Manual
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. CR-too_long Changes Requested - Your PR is too long P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SWvheerden @stringhandler @ghpbot-tari-project