Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miner and Merge mining proxy should print better pretty errors on failing grpc #5929

Closed
SWvheerden opened this issue Nov 9, 2023 · 2 comments
Closed

Miner and Merge mining proxy should print better pretty errors on failing grpc #5929

SWvheerden opened this issue Nov 9, 2023 · 2 comments
Assignees
@hansieodendaal
Labels
P-high-risk Process - High risk

Comments

@SWvheerden
Copy link
Collaborator

The miner should print pretty errors on failing grpc connection.

The miner should use a basic function like get constants or something to test the connection

And then it should use get_version to see if those methods are available.

It should print pretty and helpful error messages when those steps fail.
@SWvheerden SWvheerden added release-blocker Something that needs to be fixed before a release can be made P-high-risk Process - High risk and removed release-blocker Something that needs to be fixed before a release can be made labels Nov 17, 2023
@SWvheerden
Copy link
Collaborator Author

With the one sided coinbase, the miner should ask the for wallet address rather than fail.

@hansieodendaal hansieodendaal self-assigned this Dec 4, 2023
@hansieodendaal hansieodendaal mentioned this issue Dec 6, 2023
Merged
4 tasks
@hansieodendaal
Copy link
Contributor

See #6016

SWvheerden added a commit that referenced this issue Dec 8, 2023
@hansieodendaal @SWvheerden
feat: add miner input processing (#6016)
26f5b60 
Description
---
Added miner input processing to the minotari miner and merge mining
proxy. The miner wallet address, base node gRPC address and basic gRPC
connection will be verified.

Motivation and Context
---
Users did not have a good user experience
See #5929

How Has This Been Tested?
---
System-level testing

What process can a PR reviewer use to test or verify this change?
---
Code walk-through
System-level testing

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->

Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->

---------

Co-authored-by: SW van Heerden <swvheerden@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hansieodendaal hansieodendaal

Labels
P-high-risk Process - High risk
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SWvheerden @hansieodendaal