-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add miner input processing #6016
feat: add miner input processing #6016
Conversation
a9a4743
to
fc8ce0d
Compare
Test Results (Integration tests) 2 files + 2 1 errors 2 suites +2 1h 0m 51s ⏱️ + 1h 0m 51s For more details on these parsing errors and failures, see this check. Results for commit c3200cd. ± Comparison against base commit 0bc62b4. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lof of places where this is done:
println!("{}", msg);
error!(target: LOG_TARGET, "{}", msg);
or similar. If the log config is setup correctly, which it is by default, this will result in double logging to the terminal. We should only use println!
where absolutely required by the app for example where there is user input required. Or we wish to print out a enact message to him. General logging stuff should not be printout out to terminal.
applications/minotari_merge_mining_proxy/src/run_merge_miner.rs
Outdated
Show resolved
Hide resolved
applications/minotari_merge_mining_proxy/src/run_merge_miner.rs
Outdated
Show resolved
Hide resolved
Added miner input processing to the minotari miner and merge mining proxy. The miner wallet address, base node gRPC address and basic gRPC connection will be verified.
I tested this locally, works as intended. but this is why I don't like the double logs, it looks like its broken and looks unprofessional:
It prints most of the stuff double. The beauty of log4rs is that you can customize what is showed on terminal, if you don't want to see all of this, you can remove it. On default we choose what the user must see, but its not forced on the user. |
} | ||
|
||
/// Read base_node_socket_address arg or prompt for input | ||
pub fn base_node_socket_address( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a note here, we need to decide if this is fine or not.
Currently, the miner chooses the default address as 127.0.0.1:{Network port}
If you want a non interactive deploy, you need to set the correct default address in the config. If not the miner will block on user prompt.
Changing all the double prints: Base node not running (miner):
Base node not running (merge mining proxy):
Base node gRPC methods not enabled (miner):
Base node gRPC methods not enabled (merge mining proxy):
|
fc8ce0d
to
16fd577
Compare
Description
Added miner input processing to the minotari miner and merge mining proxy. The miner wallet address, base node gRPC address and basic gRPC connection will be verified.
Motivation and Context
Users did not have a good user experience
See #5929
How Has This Been Tested?
System-level testing
What process can a PR reviewer use to test or verify this change?
Code walk-through
System-level testing
Breaking Changes