Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: changes balance query #6158

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

SWvheerden
Copy link
Collaborator

@SWvheerden SWvheerden commented Feb 20, 2024

Description

changes balance query to be more in line with you would expect.
FFI now matches grpc

BREAKING CHANGE

This changes the external API for the wallet_ffi and the wallet library

@SWvheerden SWvheerden requested a review from a team as a code owner February 20, 2024 12:08
@SWvheerden SWvheerden changed the title FIX!: changes balance query fix!: changes balance query Feb 20, 2024
@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Feb 20, 2024
Copy link

github-actions bot commented Feb 20, 2024

Test Results (CI)

1 260 tests   1 260 ✅  23m 34s ⏱️
   39 suites      0 💤
    1 files        0 ❌

Results for commit 1c5097e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 20, 2024

Test Results (Integration tests)

 2 files  11 suites   26m 37s ⏱️
29 tests 28 ✅ 0 💤 1 ❌
30 runs  29 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 1c5097e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Feb 27, 2024
@SWvheerden SWvheerden merged commit 9ccc615 into tari-project:development Feb 27, 2024
12 of 14 checks passed
@SWvheerden SWvheerden deleted the sw_fix_balance branch March 5, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants