Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: m of n scripting poc #6377

Merged

Conversation

hansieodendaal
Copy link
Contributor

@hansieodendaal hansieodendaal commented Jun 21, 2024

Description

Apply m_of_n_feature branch

Motivation and Context

Add m-of-n scripting ability

How Has This Been Tested?

Note: Not tested yet

What process can a PR reviewer use to test or verify this change?

Code review

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@hansieodendaal hansieodendaal requested a review from a team as a code owner June 21, 2024 05:47
@hansieodendaal hansieodendaal marked this pull request as draft June 21, 2024 05:47
@hansieodendaal hansieodendaal force-pushed the ho_m_of_n_scripting_poc branch 4 times, most recently from abbb20f to 006229c Compare June 24, 2024 15:11
@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jun 24, 2024
Copy link

github-actions bot commented Jun 24, 2024

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   33m 46s ⏱️ + 33m 46s
35 tests +35  32 ✅ +32  0 💤 ±0  3 ❌ +3 
39 runs  +39  34 ✅ +34  0 💤 ±0  5 ❌ +5 

For more details on these failures, see this check.

Results for commit 01bd9b1. ± Comparison against base commit 59a3440.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 24, 2024

Test Results (CI)

    3 files    120 suites   40m 51s ⏱️
1 295 tests 1 295 ✅ 0 💤 0 ❌
3 877 runs  3 877 ✅ 0 💤 0 ❌

Results for commit 01bd9b1.

♻️ This comment has been updated with latest results.

@hansieodendaal hansieodendaal force-pushed the ho_m_of_n_scripting_poc branch from 006229c to c376147 Compare June 24, 2024 15:33
@hansieodendaal hansieodendaal marked this pull request as ready for review June 24, 2024 15:33
@hansieodendaal hansieodendaal changed the title [wip] feat: m of n scripting poc feat: m of n scripting poc Jun 24, 2024
@hansieodendaal hansieodendaal force-pushed the ho_m_of_n_scripting_poc branch from c376147 to deaf0c8 Compare June 24, 2024 15:36
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@ghpbot-tari-project ghpbot-tari-project added the CR-too_long Changes Requested - Your PR is too long label Jun 26, 2024
@hansieodendaal hansieodendaal force-pushed the ho_m_of_n_scripting_poc branch 3 times, most recently from 1ecb1c3 to 76caf29 Compare June 27, 2024 15:05
@hansieodendaal hansieodendaal force-pushed the ho_m_of_n_scripting_poc branch 2 times, most recently from 9fb8da2 to 24e05d9 Compare June 27, 2024 15:26
@hansieodendaal hansieodendaal force-pushed the ho_m_of_n_scripting_poc branch from 24e05d9 to 01bd9b1 Compare June 28, 2024 03:53
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can go in as is

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Jun 28, 2024
@SWvheerden SWvheerden merged commit fc744d0 into tari-project:development Jun 28, 2024
14 of 16 checks passed
@hansieodendaal hansieodendaal deleted the ho_m_of_n_scripting_poc branch July 9, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR-too_long Changes Requested - Your PR is too long P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants