-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: creates a wallet command to create a signature and a nonce from a private key and challenge #4776
Merged
stringhandler
merged 57 commits into
tari-project:feature-m-of-n
from
jorgeantonio21:ja-multisig-sign-message
Oct 12, 2022
Merged
feat: creates a wallet command to create a signature and a nonce from a private key and challenge #4776
stringhandler
merged 57 commits into
tari-project:feature-m-of-n
from
jorgeantonio21:ja-multisig-sign-message
Oct 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an m-of-n multisig TariScript that returns the aggregate public key of the signatories if successful and fails otherwise.
…gregatePubKey' into ja-multisig-signature-utxo
SWvheerden
reviewed
Oct 10, 2022
SWvheerden
reviewed
Oct 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good,
The signature already contains the public nonce inside of it.
Co-authored-by: SW van Heerden <swvheerden@gmail.com>
Co-authored-by: SW van Heerden <swvheerden@gmail.com>
Co-authored-by: SW van Heerden <swvheerden@gmail.com>
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Jun 24, 2024
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Jun 24, 2024
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Jun 24, 2024
4 tasks
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Jun 24, 2024
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Jun 24, 2024
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Jun 26, 2024
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Jun 27, 2024
SWvheerden
pushed a commit
that referenced
this pull request
Jun 28, 2024
Description --- Apply m_of_n_feature branch - PR #4751 - PRs #4759, #4776, #4798, #4822 Motivation and Context --- Add m-of-n scripting ability How Has This Been Tested? --- **Note:** Not tested yet What process can a PR reviewer use to test or verify this change? --- Code review <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is desirable to have a wallet cli command to create and display (on terminal) a signature and nonce, from the given of a private key and challenge.
Motivation and Context
This PR addresses the above task.
How Has This Been Tested?
Unit tests