Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: creates a wallet command to create a signature and a nonce from a private key and challenge #4776

Conversation

jorgeantonio21
Copy link
Contributor

@jorgeantonio21 jorgeantonio21 commented Oct 5, 2022

Description

It is desirable to have a wallet cli command to create and display (on terminal) a signature and nonce, from the given of a private key and challenge.

Motivation and Context

This PR addresses the above task.

How Has This Been Tested?

Unit tests

jorgeantonio21 and others added 30 commits September 27, 2022 18:13
Added an m-of-n multisig TariScript that returns the aggregate public key of
the signatories if successful and fails otherwise.
…gregatePubKey' into ja-multisig-signature-utxo
@jorgeantonio21 jorgeantonio21 changed the base branch from development to feature-m-of-n October 6, 2022 16:18
@jorgeantonio21 jorgeantonio21 marked this pull request as ready for review October 6, 2022 21:16
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,
The signature already contains the public nonce inside of it.

stringhandler and others added 3 commits October 12, 2022 09:01
Co-authored-by: SW van Heerden <swvheerden@gmail.com>
Co-authored-by: SW van Heerden <swvheerden@gmail.com>
Co-authored-by: SW van Heerden <swvheerden@gmail.com>
@stringhandler stringhandler merged commit 46310ba into tari-project:feature-m-of-n Oct 12, 2022
hansieodendaal added a commit to hansieodendaal/tari that referenced this pull request Jun 24, 2024
hansieodendaal added a commit to hansieodendaal/tari that referenced this pull request Jun 24, 2024
hansieodendaal added a commit to hansieodendaal/tari that referenced this pull request Jun 24, 2024
@hansieodendaal hansieodendaal mentioned this pull request Jun 24, 2024
4 tasks
hansieodendaal added a commit to hansieodendaal/tari that referenced this pull request Jun 24, 2024
hansieodendaal added a commit to hansieodendaal/tari that referenced this pull request Jun 24, 2024
hansieodendaal added a commit to hansieodendaal/tari that referenced this pull request Jun 26, 2024
hansieodendaal added a commit to hansieodendaal/tari that referenced this pull request Jun 27, 2024
SWvheerden pushed a commit that referenced this pull request Jun 28, 2024
Description
---

Apply m_of_n_feature branch

- PR #4751
- PRs #4759, #4776, #4798, #4822

Motivation and Context
---

Add m-of-n scripting ability

How Has This Been Tested?
---

**Note:** Not tested yet

What process can a PR reviewer use to test or verify this change?
---

Code review

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants