Request PoW target difficulty for miner from the base node #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonknight64
force-pushed
the
yuko-#1067-request_target_difficulty_for_miner_from_basenode
branch
from
42ece20 to
fd34167
Compare
SWvheerden
reviewed
Dec 2, 2019
neonknight64
force-pushed
the
yuko-#1067-request_target_difficulty_for_miner_from_basenode
branch
from
fd34167 to
323bd1e
Compare
…e chain state to calculate the target difficulty of the different PoW algorithms. - Added the GetTargetDifficulty comms request and TargetDifficulty comms response to the BaseNodeService allowing miners to request the target difficulty from a Base node. - Added proto conversions for the GetTargetDifficulty request and TargetDifficulty response. - Added the difficulty adjustment manager to the tari base node and existing tests. - Fixed 0 difficulty issue in Lwma_diff and change it to make use of the correct target time. Changed it to make the target time configurable. - Added a test for testing the the get target difficulty request and response system and tests for the DiffAdjManager system.
neonknight64
force-pushed
the
yuko-#1067-request_target_difficulty_for_miner_from_basenode
branch
from
323bd1e to
d1c5041
Compare
CjS77
approved these changes
Dec 3, 2019
| DifficultyAdjustmentError(DifficultyAdjustmentError), | ||
| ChainStorageError(ChainStorageError), | ||
| EmptyBlockchain, | ||
| PoisonedAccess, |
There was a problem hiding this comment.
I think I've mentioned this before, but I'd rather not lift RWLock errors to the caller -- there's no real action they can take, right; it's usually a sign of a bug? I'd just bundle this in with the general error case with a suitable message.
|
|
||
| /// DiffAdjManager makes use of DiffAdjStorage to provide thread save access to its LinearWeightedMovingAverages for | ||
| /// each PoW algorithm. | ||
| pub struct DiffAdjStorage<T> |
There was a problem hiding this comment.
This is a lot of code for a "keep a running list of the last N block data"-- it works, so we'll leave it as is, but did you consider any other strategies?:
- Use VecDequeues and just update from the DB every time? i.e. assume we're always in
SyncToTipbut you pop off the front and push to the back until you have enough data - Or make it someone else's job to keep the Queues up to date (like a subscriber to a newBlock message)
CjS77
added a commit
that referenced
this pull request
Dec 3, 2019
Merge pull request #1085 - Introduced the difficulty adjustment manager that keeps track of the chain state to calculate the target difficulty of the different PoW algorithms. - Added the GetTargetDifficulty comms request and TargetDifficulty comms response to the BaseNodeService allowing miners to request the target difficulty from a Base node. - Added proto conversions for the GetTargetDifficulty request and TargetDifficulty response. - Added the difficulty adjustment manager to the tari base node and existing tests. - Fixed 0 difficulty issue in Lwma_diff and change it to make use of the correct target time. Changed it to make the target time configurable. - Added a test for testing the the get target difficulty request and response system and tests for the DiffAdjManager system. (#1085)
CjS77
deleted the
yuko-#1067-request_target_difficulty_for_miner_from_basenode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Enables miners to query a Base node to determine the target difficulty for a specified PoW algorithm.
How Has This Been Tested?
Added a test for testing the the get target difficulty request and response system and tests for the DiffAdjManager system.
Types of changes
Checklist:
developmentbranchcargo-fmt --allbefore pushing