fix: update transaction status from broadcast if already mined #3101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transaction status was not updated in the broadcast protocol monitoring loop if detected that it was already mined; added the transaction mined to the event publisher.
stringhandler
approved these changes
Jul 19, 2021
|
PR queued successfully. Your position in queue is: 1 |
|
PR failed to merge with reason: Failed due to unknown reason |
stringhandler
changed the title
|
PR queued successfully. Your position in queue is: 1 |
|
PR failed to merge with reason: Ready label was manually removed |
|
PR queued successfully. Your position in queue is: 1 |
1 similar comment
|
PR queued successfully. Your position in queue is: 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the transaction status from broadcast if already mined.
Motivation and Context
Transaction status was not updated in the broadcast protocol monitoring loop if detected that it was already mined; added the transaction mined to the event publisher. A wallet restart was required to update the status.
How Has This Been Tested?
Unit testing. Will still monitor in future stress tests.
Checklist:
developmentbranch.