fix: update LibWallet wallet_import_utxo method to include valid TariScript
#3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
changed the title
wallet_import_utxo method to include valid TariScriptwallet_import_utxo method to include valid TariScript
|
Waiting for approval before queuing |
philipr-za
force-pushed
the
philip-ffi-import
branch
from
2eb1b13 to
628ea37
Compare
…cript The `wallet_import_utxo` FFI function in LibWallet just used defaults for a number of the new UTXO fields when importing a faucet UTXO. The Faucet UTXO provided by the client is just the spending key and amount. The `metadata_signature` and `sender_offset_public_key` can both remain as default values as they are not used in spending an UTXO. A Nop script is assumed and the spending key is used as the `script_private_key`. The final update is that the `input_data` it set as the public key of the spending key. To test that the base node is happy for an UTXO imported in this way to be spent a Cucumber test is provided which imports a UTXO into a wallet and zeroes out the `metadata_signature` and`sender_offset_public_key` and updates the `input_data` and `script_private_key` in the same way as described above. This imported Faucet utxo is then successfully spent to another wallet.
philipr-za
force-pushed
the
philip-ffi-import
branch
from
628ea37 to
7d6f7a5
Compare
|
PR queued successfully. Your position in queue is: 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
wallet_import_utxoFFI function in LibWallet just used defaults for a number of the new UTXO fields when importing a faucet UTXO. The Faucet UTXO provided by the client is just the spending key and amount. Themetadata_signatureandsender_offset_public_keycan both remain as default values as they are not used in spending an UTXO. A Nop script is assumed and the spending key is used as thescript_private_key. The final update is that theinput_datait set as the public key of the spending key.To test that the base node is happy for an UTXO imported in this way to be spent a Cucumber test is provided which imports a UTXO into a wallet and zeroes out the
metadata_signatureandsender_offset_public_keyand updates theinput_dataandscript_private_keyin the same way as described above. This imported Faucet utxo is then successfully spent to another wallet.How Has This Been Tested?
Cucumber test provided
Checklist:
developmentbranch.