test: use TCP node for daily sync test #3464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
changed the title
sdbondi
force-pushed
the
dailies-use-tcp-bypass
branch
3 times, most recently
from
5375dc4 to
3d1cb57
Compare
stringhandler
previously approved these changes
Oct 18, 2021
|
Just noticed that many cucumber tests failed, probably something in this PR - will check it out |
sdbondi
force-pushed
the
dailies-use-tcp-bypass
branch
2 times, most recently
from
cd33ba1 to
12d93c3
Compare
sdbondi
force-pushed
the
dailies-use-tcp-bypass
branch
2 times, most recently
from
79b3bd2 to
b8d7265
Compare
- uses TCP node (london) for sync tests - `--force-sync-peers` option now takes the pubkey/address of the peer rather than a seed peer index - Bypass tor for TCP in sync test
sdbondi
force-pushed
the
dailies-use-tcp-bypass
branch
from
b8d7265 to
19e8b83
Compare
|
All cucumbers pass now - fixed this one in last commit |
stringhandler
approved these changes
Oct 21, 2021
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 21, 2021
…ct-chain-metadata * development: fix: fix recovery test reporting message (tari-project#3479) chore: improve cucumber tests to wait for broadcast (tari-project#3461) test: use TCP node for daily sync test (tari-project#3464)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 25, 2021
* development: (31 commits) feat!: revalidate all outputs (tari-project#3471) fix: check SAF message inflight and check stored_at is in past (tari-project#3444) feat!: apps should not depend on other app configs (tari-project#3469) fix: fix recovery test reporting message (tari-project#3479) chore: improve cucumber tests to wait for broadcast (tari-project#3461) test: use TCP node for daily sync test (tari-project#3464) fix: remove unbounded vec allocations from base node grpc/p2p messaging (tari-project#3467) fix: upgrade rustyline dependencies (tari-project#3476) fix(dht): discard encrypted message with no destination (tari-project#3472) fix: remove consensus breaking change in transaction input (tari-project#3474) feat: tx weight takes tariscript and output features into account [igor] (tari-project#3411) fix: validate dht header before dedup cache (tari-project#3468) fix: sha256sum isn't available on all *nix platforms (tari-project#3466) fix: typo in console wallet (tari-project#3465) fix: ensure that accumulated orphan chain data is committed before header validation (tari-project#3462) fix: remove is_synced check for transaction validation (tari-project#3459) feat: improve logging for tari_mining_node (tari-project#3449) fix: remove unnecessary wallet dependency (tari-project#3438) test: simplify cucumber tests (tari-project#3457) ci: create script to update DNS records from hashes.txt (tari-project#3458) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--force-sync-peersoption now takes the pubkey/address of the peerrather than a seed peer index
When a new node joins the network, it should receive all peerscucumberMotivation and Context
The primary goal of the daily sync test is to provide visibility into the performance of the sync protocol.
Directly connecting to the same TCP node, bypassing the tor network, the network performance under which the sync protocol runs is more consistent.
How Has This Been Tested?
Run locally