fix: edge case fix for integer pair iter #3508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
approved these changes
Oct 28, 2021
stringhandler
added a commit
that referenced
this pull request
Nov 4, 2021
BREAKING CHANGES * implement new CipherSeed and upgrade encryption KDF (#3505) Features * add a Rejected status to TransactionStatus ([#3512](#3512)) ([c65a01c](c65a01c)) * add caching and clippy annotations to CI ([#3518](#3518)) ([beacb9e](beacb9e)) * implement new CipherSeed and upgrade encryption KDF ([#3505](#3505)) ([ef4f84f](ef4f84f)) Bug Fixes * edge case fix for integer pair iter ([#3508](#3508)) ([097e3e2](097e3e2)) * header sync must allow transition to archival/pruned if tip is behind ([#3520](#3520)) ([e028386](e028386))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
start = 255u8 and end = 255MAX - 1Motivation and Context
Passing
start = 255u8 and end = 255into the iterator resulted in a non-terminating iterator.This iterator is used for pagination on the database and grpc handlers
How Has This Been Tested?
Unit tests for this case