Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unique_id block validator tests #3510

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Oct 28, 2021

Description

  • Add some tests for unique_id validation
  • breaking change: Use version 1 blocks for localnet, igor and dibbler (kernel ordering, mmr without empty bitmap)
  • Add mmr to test blocks in blockchain database so that concrete validation impls can be tested

Motivation and Context

These are not complete as more work needs to happen to complete the validations

How Has This Been Tested?

Tests pass

@sdbondi sdbondi force-pushed the core-unique-id-validations-tests branch from c9f83cf to da45707 Compare October 28, 2021 13:36
@sdbondi sdbondi changed the title tests!: add unique_id block validator tests test!: add unique_id block validator tests Oct 28, 2021
@stringhandler stringhandler changed the title test!: add unique_id block validator tests test: add unique_id block validator tests Oct 28, 2021
Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@stringhandler stringhandler merged commit 152c660 into tari-project:validator-node Oct 28, 2021
@sdbondi sdbondi deleted the core-unique-id-validations-tests branch October 28, 2021 15:24
sdbondi added a commit to sdbondi/tari that referenced this pull request Nov 3, 2021
* validator-node:
  tests!: add unique_id block validator tests (tari-project#3510)
@sdbondi sdbondi restored the core-unique-id-validations-tests branch February 3, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants