feat: add asset proxy #3659
Merged
feat: add asset proxy #3659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
force-pushed
the
mb-asset-proxy
branch
from
35af13e to
b818429
Compare
stringhandler
force-pushed
the
mb-asset-proxy
branch
from
b818429 to
657c9b3
Compare
# Conflicts: # integration_tests/features/support/validator_node_steps.js # integration_tests/helpers/config.js
sdbondi
reviewed
Dec 16, 2021
| message Authority { | ||
| bytes node_public_key =1; | ||
| bytes signature = 2; | ||
| optional bytes proxied_by = 3; |
There was a problem hiding this comment.
I think the optional keyword was taken out in proto3
There was a problem hiding this comment.
Yeah I also thought that was the case, but for byte arrays, it converts to an Option<Vec> instead of a Vec so it's easier to test if it was specified. AFAIK optional is still allowed for some types
applications/tari_validator_node/src/p2p/services/rpc_client.rs
Outdated
Show resolved
Hide resolved
Cifko
reviewed
Dec 17, 2021
| @@ -69,7 +72,9 @@ impl TariCommsInboundConnectionService { | |||
| loop { | |||
| futures::select! { | |||
| message = inbound_stream.select_next_some() => { | |||
| self.forward_message(message).await?; | |||
|
|
|||
| self.forward_message(message).await?; | |||
There was a problem hiding this comment.
Looks like you haven't run the formatter.
Cifko
previously approved these changes
Dec 17, 2021
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 5, 2022
* development: fix: allow 0-conf in blockchain db (tari-project#3680) test: fix cucumber WalletQuery.feature (tari-project#3677) test: fix `wait for` step (tari-project#3673) perf(comms)!: optimise connection establishment (tari-project#3658) fix: remove noise negotiation for debugging on bad wire mode (tari-project#3657) feat: add follow on checkpoint (tari-project#3676) ci: fix tari collectibles build (tari-project#3670) feat: example to generate vanity node_ids (tari-project#3654) fix: prefer configured seeds over dns seeds (tari-project#3662) docs: update RFC-0230_HTLC to use TariScript (tari-project#3622) feat: add invoke write method to proxy (tari-project#3667) ci: add tauri build (tari-project#3669) test: fix cucumber metadata signature (tari-project#3665) feat: add asset proxy (tari-project#3659) test: fix cucumber (tari-project#3660)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 5, 2022
* development: fix: allow 0-conf in blockchain db (tari-project#3680) test: fix cucumber WalletQuery.feature (tari-project#3677) test: fix `wait for` step (tari-project#3673) perf(comms)!: optimise connection establishment (tari-project#3658) fix: remove noise negotiation for debugging on bad wire mode (tari-project#3657) feat: add follow on checkpoint (tari-project#3676) ci: fix tari collectibles build (tari-project#3670) feat: example to generate vanity node_ids (tari-project#3654) fix: prefer configured seeds over dns seeds (tari-project#3662) docs: update RFC-0230_HTLC to use TariScript (tari-project#3622) feat: add invoke write method to proxy (tari-project#3667) ci: add tauri build (tari-project#3669) test: fix cucumber metadata signature (tari-project#3665) feat: add asset proxy (tari-project#3659) test: fix cucumber (tari-project#3660)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an proxy to forward requests to the asset committee