Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validator node shows its public key on startup #3734

Merged
merged 1 commit into from
Jan 24, 2022
Merged

feat: validator node shows its public key on startup #3734

merged 1 commit into from
Jan 24, 2022

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jan 24, 2022 •
edited
Loading

Description

  • Displays the validator node network identity information on startup
  • Only resign the node identity if the public address has changed.

Motivation and Context

Previously, you would have to look in the logs to obtain this public key

How Has This Been Tested?

Manually

🚀 Validator node started!
Public Key: aefbe6559c06bb4a7f7f04307651e9263c15a7f0be3a19a4f59e2c928d5ec333
Node ID: 1bdaf4a679ce426c3178460e7a
Public Address: /onion3/fsag2su6pao5cbosz3wqy6x73x3yb7cinpsqzubrajhhn4emqrzxgvqd:18141
Features: NONE | COMMUNICATION_CLIENT

SWvheerden
SWvheerden previously approved these changes Jan 24, 2022
View reviewed changes
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdbondi sdbondi force-pushed the vn-show-public-key branch from b16a001 to 70503c7 Compare January 24, 2022 06:21
@aviator-app aviator-app bot merged commit fc7da51 into tari-project:development Jan 24, 2022
@sdbondi sdbondi deleted the vn-show-public-key branch January 24, 2022 07:23
@sdbondi sdbondi restored the vn-show-public-key branch February 3, 2022 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

@delta1 delta1 delta1 approved these changes

@SWvheerden SWvheerden SWvheerden left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdbondi @delta1 @SWvheerden @stringhandler