Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor fixes on collectibles #3795

Merged
merged 3 commits into from
Feb 5, 2022
Merged

fix: minor fixes on collectibles #3795

merged 3 commits into from
Feb 5, 2022

Conversation

delta1
Copy link
Contributor

@delta1 delta1 commented Feb 3, 2022

Description

  • bumps anyhow crate, wanted to use it for collectibles but the tauri error doesn't implement sync for some reason
  • adds a default impl for CollectiblesConfig, since trying to run it with npm start from the folder would error
  • fix asset class image

@aviator-app aviator-app bot added the mq-failed label Feb 4, 2022
@delta1 delta1 removed the mq-failed label Feb 5, 2022
@aviator-app aviator-app bot merged commit cfc42dd into tari-project:development Feb 5, 2022
sdbondi added a commit to sdbondi/tari that referenced this pull request Feb 8, 2022
@sdbondi
Merge branch 'development' into core-sync-latency-based-peer-switch
504529f 
* development:
  refactor: reduce log level of some messages (tari-project#3804)
  ci: move Apple IDs into envs (tari-project#3797)
  feat: read asset definitions from base layer (tari-project#3802)
  fix: bump flood ban messages config (tari-project#3799)
  docs: readme fixes (tari-project#3800)
  feat(wallet_ffi)!:  add base node connectivity callback to wallet ffi (tari-project#3796)
  fix: minor fixes on collectibles (tari-project#3795)
  refactor: outbound message pipeline, threads and mempool improvements (tari-project#3792)
  feat(collectibles): add delete committee member button (tari-project#3786)
  fix(comms): minor edge-case fix to handle inbound connection while dialing (tari-project#3785)
  fix(core)!: fix potential panic for sidechain merkle root with incorrect length (tari-project#3788)
  fix(core): reduce one block behind waiting period (tari-project#3798)
  feat: add specific LibWallet error code for “Fee is greater than amount” (tari-project#3793)
  fix: coinbase output recovery bug (tari-project#3789)
  feat(base-node): add number of active sync peers metric (tari-project#3784)
  chore: script to keep .gitkeep file (tari-project#3787)
  feat: re-use scanned range proofs (tari-project#3764)
  feat: ability to compile on stable rust (tari-project#3759)
  feat: add logging and config to collectibles (tari-project#3781)
  chore: remove debug info from get-mempool-state (tari-project#3782)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delta1 @stringhandler