feat(validator-node): initial state sync implementation (partial) #3826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
vn-state-sync-methods
branch
2 times, most recently
from
278fcfe to
e32070e
Compare
sdbondi
force-pushed
the
vn-state-sync-methods
branch
from
e32070e to
0a3ddf2
Compare
stringhandler
previously approved these changes
Feb 14, 2022
|
|
||
| message StateOpLog { | ||
| uint64 height = 1; | ||
| string operation = 2; |
There was a problem hiding this comment.
perhaps an enum here rather?
There was a problem hiding this comment.
Yeah probably, I'm using this "weirdly" as a single char enum - S = Set, D = Delete etc. but an enum is more standard :P
| @@ -89,12 +89,12 @@ impl AssetProcessor for ConcreteAssetProcessor { | |||
| ) | |||
| } | |||
|
|
|||
| fn invoke_read_method<TUnifOfWork: StateDbUnitOfWork>( | |||
| fn invoke_read_method<TUnitOfWork: StateDbUnitOfWorkReader>( | |||
There was a problem hiding this comment.
Nice. Perhaps we need a better name, but I like it
There was a problem hiding this comment.
Yeah it's a bit long, open to suggestions/change later
stringhandler
approved these changes
Feb 15, 2022
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Feb 17, 2022
* development: (28 commits) fix(wallet): fix aggressive disconnects in wallet connectivity (tari-project#3807) chore: honor decimals in ERC20 (tari-project#3809) chore: add icons to applications (tari-project#3812) fix: daily test (tari-project#3815) ci: improvements to macos pkg (tari-project#3824) ci: cargo test speedups (tari-project#3843) feat: add persistence of transaction cancellation reason to wallet db (tari-project#3842) fix: update RFC links and README (tari-project#3675) (tari-project#3839) chore: change NodeIdentity debug (tari-project#3817) fix(dan): include state_root in node hash (tari-project#3836) feat(cli): resize terminal height (tari-project#3838) feat(validator-node): initial state sync implementation (partial) (tari-project#3826) feat: update console wallet tui (tari-project#3837) feat: resize base node terminal on startup (tari-project#3827) feat(wallet): add grpc method for setting base node (tari-project#3828) chore(deps): bump follow-redirects from 1.14.5 to 1.14.8 in /applications/tari_web_extension_example (tari-project#3832) chore(deps): bump follow-redirects from 1.14.7 to 1.14.8 in /applications/tari_collectibles/web-app (tari-project#3833) chore(deps): bump follow-redirects from 1.14.5 to 1.14.8 in /applications/tari_web_extension (tari-project#3834) chore(deps): bump follow-redirects from 1.14.7 to 1.14.8 in /applications/launchpad/gui-vue (tari-project#3831) chore(deps): bump follow-redirects from 1.14.4 to 1.14.8 in /integration_tests (tari-project#3829) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Validator node on a committee needs to sync their state after going offline.
How Has This Been Tested?
Manually, it didnt work because the merkle root of the initial checkpoint is incorrect. Sync component has been hardcoded to always say it is in sync for now.