refactor: use clap as a commands parser #3867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
reviewed
Feb 22, 2022
| node_id: UniNodeId, | ||
| /// length of time to ban the peer for in seconds | ||
| #[clap(default_value_t = std::u64::MAX)] | ||
| lenght: u64, |
There was a problem hiding this comment.
Suggested change
| lenght: u64, | |
| length: u64, |
Maybe time_secs is better but up to you
therustmonk
force-pushed
the
clap-commands
branch
2 times, most recently
from
4f35513 to
0bb2089
Compare
sdbondi
previously approved these changes
Mar 7, 2022
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 7, 2022
3867: refactor: use clap as a commands parser r=sdbondi a=DenisKolodin Description --- The PR refactors replace our own parser with a derived by the `clap` crate. It also adds the `watch` command, and avoids unexpected status printing. Motivation and Context --- Improve the user experience of the node's shell. Simplify maintenance and adding new commands. Also periodically status prnting breaks the rustyline and prompt chars not printed properly. How Has This Been Tested? --- Manually 3892: chore: add license info missing from some crates r=sdbondi a=delta1 Description --- Adds the BSD-3-Clause license field to our crates that were missing license info Co-authored-by: Denis Kolodin <deniskolodin@gmail.com> Co-authored-by: Byron Hambly <bizzle@tari.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Mar 7, 2022
Description --- The PR refactors replace our own parser with a derived by the `clap` crate. It also adds the `watch` command, and avoids unexpected status printing. Motivation and Context --- Improve the user experience of the node's shell. Simplify maintenance and adding new commands. Also periodically status prnting breaks the rustyline and prompt chars not printed properly. How Has This Been Tested? --- Manually
|
Build failed: |
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Mar 7, 2022
Description --- The PR refactors replace our own parser with a derived by the `clap` crate. It also adds the `watch` command, and avoids unexpected status printing. Motivation and Context --- Improve the user experience of the node's shell. Simplify maintenance and adding new commands. Also periodically status prnting breaks the rustyline and prompt chars not printed properly. How Has This Been Tested? --- Manually
|
Build failed: |
|
Seems like something has broken in the integration tests? @deniskolodin |
therustmonk
force-pushed
the
clap-commands
branch
2 times, most recently
from
cf88ec1 to
b007757
Compare
therustmonk
force-pushed
the
clap-commands
branch
3 times, most recently
from
49dfd64 to
4e06e66
Compare
therustmonk
force-pushed
the
clap-commands
branch
from
4e06e66 to
25dde41
Compare
stringhandler
previously approved these changes
Mar 14, 2022
therustmonk
force-pushed
the
clap-commands
branch
2 times, most recently
from
1159474 to
df762f9
Compare
therustmonk
force-pushed
the
clap-commands
branch
from
df762f9 to
9847ad8
Compare
stringhandler
approved these changes
Mar 15, 2022
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Mar 15, 2022
* development: (118 commits) chore: clean up providing seed words from LibWallet (tari-project#3906) chore: move tari_script into its own crate (tari-project#3909) fix(consensus): check blockchain version within valid range (tari-project#3916) ci: fix missing npm deps and add javascript ci (tari-project#3910) refactor: use clap as a commands parser (tari-project#3867) chore: use git tagged tari_utilities and tari-crypto deps (tari-project#3913) fix: aligned tables left (tari-project#3899) ci: fix vue build v0.29.0 feat!: add recovery byte to output features (tari-project#3727) add ffi ci check (tari-project#3915) fix(block-sync): use avg latency to determine slow sync peer for block sync (tari-project#3912) fix: fix merge mining proxy pool mining (tari-project#3814) revert: remove use of blocking tasks for DHT db (reverts tari-project#3887) (tari-project#3901) chore: add license info missing from some crates (tari-project#3892) fix(core): correctly filter pruned sync peers for block sync (tari-project#3902) ci: revert bors squash merge (tari-project#3900) fix: update metadata size calculation to use FixedSet.iter() docs(rfc): deep links structure convention - deep links is use (tari-project#3897) ci: use squash merge for bors (tari-project#3896) ...
sdbondi
added a commit
to Cifko/tari
that referenced
this pull request
Mar 16, 2022
* development: chore: clean up providing seed words from LibWallet (tari-project#3906) chore: move tari_script into its own crate (tari-project#3909) fix(consensus): check blockchain version within valid range (tari-project#3916) ci: fix missing npm deps and add javascript ci (tari-project#3910) refactor: use clap as a commands parser (tari-project#3867) chore: use git tagged tari_utilities and tari-crypto deps (tari-project#3913) fix: aligned tables left (tari-project#3899) ci: fix vue build v0.29.0 feat!: add recovery byte to output features (tari-project#3727) add ffi ci check (tari-project#3915)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR refactors replace our own parser with a derived by the
clapcrate.It also adds the
watchcommand, and avoids unexpected status printing.More changes:
non-interactivemode--watchparameter to thenon-interactivemode to run a command with an intervalwatchcommand to the interactive modeMotivation and Context
Improve the user experience of the node's shell.
Simplify maintenance and adding new commands.
Also periodically status prnting breaks the rustyline and prompt chars not printed properly.
How Has This Been Tested?
Manually