Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use standard lint settings and fix lints #4066

Merged
merged 32 commits into from
May 16, 2022
Merged

chore: use standard lint settings and fix lints #4066

merged 32 commits into from
May 16, 2022

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Apr 29, 2022 •
edited
Loading

Description

  • updates lints.toml to match tari-meta
  • fixes a number of clippy minor lints

Motivation and Context

Tari repo uses standard linter settings EDIT: there are too many cast clippys to investigate, so that is left for another PR

Larger fixes are in #4063 #4064 #4065 which should be merged before this PR.

How Has This Been Tested?

cargo lints clippy passes

@sdbondi sdbondi force-pushed the clippy-warn-fixes branch from 2a79468 to 3c285fd Compare April 29, 2022 14:28
@sdbondi sdbondi force-pushed the clippy-warn-fixes branch from 67631e7 to 20be2e4 Compare May 6, 2022 08:03
@sdbondi sdbondi marked this pull request as ready for review May 6, 2022 08:03
@sdbondi sdbondi force-pushed the clippy-warn-fixes branch 2 times, most recently from 5a96d58 to d6cfb6d Compare May 6, 2022 08:09
@sdbondi sdbondi force-pushed the clippy-warn-fixes branch from d6cfb6d to 8614822 Compare May 6, 2022 08:11
@sdbondi sdbondi force-pushed the clippy-warn-fixes branch from c02f8fa to eac5753 Compare May 6, 2022 08:35
@sdbondi
Copy link
Member Author

sdbondi commented May 13, 2022

@SWvheerden @deniskolodin Can I have a review on this one? It may be easier to check each of the commits individually.

SWvheerden
SWvheerden reviewed May 13, 2022
View reviewed changes
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.
The only thing I think we need to add is todo's and a good first issue in github so we can tackle some of these large functions. We have way too many of them.

applications/tari_console_wallet/src/recovery.rs Show resolved Hide resolved
base_layer/core/src/base_node/rpc/service.rs Show resolved Hide resolved
base_layer/core/src/base_node/sync/block_sync/synchronizer.rs Show resolved Hide resolved
base_layer/core/src/base_node/sync/horizon_state_sync/synchronizer.rs Show resolved Hide resolved
base_layer/core/src/mempool/mod.rs Show resolved Hide resolved
base_layer/core/src/mempool/sync_protocol/mod.rs Show resolved Hide resolved
@sdbondi
Copy link
Member Author

sdbondi commented May 13, 2022

@SWvheerden definitely agree, the intention here was to mark them so that they can be fixed later. Searching for too_many_lines should do it so don't think we need a Todo above each of them.

therustmonk
therustmonk previously approved these changes May 15, 2022
View reviewed changes
Copy link
Contributor

@therustmonk therustmonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pretty huge, but I haven't serious admonitions here

@aviator-app aviator-app bot merged commit 6163d7b into tari-project:development May 16, 2022
@sdbondi sdbondi deleted the clippy-warn-fixes branch May 16, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWvheerden SWvheerden SWvheerden left review comments

@stringhandler stringhandler stringhandler approved these changes

@therustmonk therustmonk therustmonk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdbondi @therustmonk @SWvheerden @stringhandler