fix(dan_layer/core): include state root in checkpoint signature #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This challenge wil be reused in base layer validations
stringhandler
approved these changes
Jul 7, 2022
jorgeantonio21
added a commit
to jorgeantonio21/tari
that referenced
this pull request
Jul 8, 2022
…re (tari-project#4285)" This reverts commit bcaabf0.
aviator-app bot
pushed a commit
that referenced
this pull request
Jul 12, 2022
Description --- * New base layer validation of checkpoint signatures: verifies that ALL the signatures present in the checkpoint are valid * Unified the error type for invalid signatures across all contract output types Motivation and Context --- The base layer needs to check if all the signatures in a checkpoint are valid. This PR is based on previous work on checkpoints (see #4261 and #4285). The checkpoint signature is calculated as: `e = H_1(signer_public_key || public_nonce || H_2(contract_id||commitment||merkle_root||checkpoint_number))` But take into account that the `commitment` is still a mock value as of now we still don't have a method for creating a shared value. How Has This Been Tested? --- New unit test checks that invalid signatures are detected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SignerSignatureprivatesign_checkpointmethod toSigningServiceMotivation and Context
Generates the state root for the pre-committed state and includes that in the checkpoint signatures on the commit step
instead of a dummy value for the state root.
BUG: the state root MMR only includes state updates for existing keys and does not include new keys. This was a pre-existing bug
TODO: Share a blinding factor seed between validators and derive checkpoint blinding factors. Currently, a zero commitment is included in the checkpoint signature and a random blinding factor generated by the VN wallet is used in the checkpoint output.
How Has This Been Tested?
Manually, signatures are included in the checkpoint