fix: use SafePassword struct instead of String for passwords #4320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therustmonk
force-pushed
the
dk-zeroize-wallet-config
branch
from
2d9f2d2 to
94136a8
Compare
therustmonk
force-pushed
the
dk-zeroize-wallet-config
branch
2 times, most recently
from
5d383e8 to
057e76b
Compare
therustmonk
force-pushed
the
dk-zeroize-wallet-config
branch
from
af6a5e0 to
641c855
Compare
therustmonk
force-pushed
the
dk-zeroize-wallet-config
branch
from
641c855 to
9c7b092
Compare
stringhandler
approved these changes
Aug 3, 2022
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Aug 4, 2022
* development: fix: wallet database encryption does not bind to field keys tari-project#4137 (tari-project#4340) fix: use SafePassword struct instead of String for passwords (tari-project#4320) feat(dan): template macro handles component state (tari-project#4380) fix(dht)!: add message padding for message decryption, to reduce message length leaks (fixes tari-project#4140) (tari-project#4362) fix(wallet): update seed words for output manager tests (tari-project#4379)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update replaces
Stringtypes withSafePasswordwrapper to be sure app the passwords:Related: tari-project/tari_utilities#46
Motivation and Context
To guarantee all the passphrases erased.
How Has This Been Tested?
CI