-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor incorrect cucumber test on burn funds via cli #4679
Changes from all commits
388cb9c
92090f5
017c164
bd428ed
56898f9
81700a6
22abb29
db8671e
6f91452
dcd90fe
4f541a1
c9ab8cb
964e358
ee3db55
5e89d19
846a6dd
0912b2c
ad2744a
31965a0
c5161b6
01ab4d6
98fbe8f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -53,20 +53,22 @@ Feature: Wallet CLI | |||||||||||
And mining node MINE mines 5 blocks | ||||||||||||
Then I wait for wallet RECEIVER to have at least 1000000 uT | ||||||||||||
|
||||||||||||
|
||||||||||||
@critical | ||||||||||||
Scenario: As a user I want to burn tari via command line | ||||||||||||
Given I have a seed node SEED | ||||||||||||
And I have a base node BASE connected to seed SEED | ||||||||||||
And I have wallet WALLET_A connected to base node BASE | ||||||||||||
And I have wallet WALLET_B connected to base node BASE | ||||||||||||
And I have mining node MINER_A connected to base node BASE and wallet WALLET_A | ||||||||||||
And I have mining node MINER_B connected to base node BASE and wallet WALLET_B | ||||||||||||
And mining node MINER_A mines 15 blocks | ||||||||||||
And I have wallet WALLET connected to base node BASE | ||||||||||||
And I have mining node MINER connected to base node BASE and wallet WALLET | ||||||||||||
And mining node MINER mines 12 blocks | ||||||||||||
Then I mine 3 blocks on BASE | ||||||||||||
Then all nodes are at height 15 | ||||||||||||
When I wait for wallet WALLET_A to have at least 55000000000 uT | ||||||||||||
When I create a burn transaction of 45000000000 uT from WALLET_A via command line | ||||||||||||
Then I have mining node MINER_B mines 10 blocks | ||||||||||||
Then I get balance of wallet WALLET_A is at least 10000000000 uT via command line | ||||||||||||
When I wait for wallet WALLET to have at least 221552530060 uT | ||||||||||||
When I create a burn transaction of 201552500000 uT from WALLET via command line | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line currently does not spend all UTXOs in the wallet, but it shoud. The average coinbase for the 1st 12 blocks is
Suggested change
We can also restart the wallet here as waiting for the change UTXO to be received and confirmed does not need to be via the command line |
||||||||||||
When I mine 5 blocks on BASE | ||||||||||||
Then all nodes are at height 20 | ||||||||||||
# Then I wait for wallet WALLET to have at least 100 uT | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
This line is important to ensure the wallet received the change UTXO (worth |
||||||||||||
Then I get balance of wallet WALLET is at most 18462621580 uT via command line | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||
# TODO: verify the actual burned kernel | ||||||||||||
|
||||||||||||
@long-running | ||||||||||||
Scenario: As a user I want to send one-sided via command line | ||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could probably mine fewer blocks to make the calculations easier