Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove tracing_subscriber #4906

Merged
merged 1 commit into from
Nov 11, 2022
Merged

feat: remove tracing_subscriber #4906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
218 changes: 6 additions & 212 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions applications/tari_base_node/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,6 @@ tokio = { version = "1.20", features = ["signal"] }
tonic = "0.6.2"
tracing = "0.1.26"

# network tracing, rt-tokio for async batch export
opentelemetry = { version = "0.16", default-features = false, features = ["trace", "rt-tokio"] }
opentelemetry-jaeger = { version = "0.15", features = ["rt-tokio", "collector_client", "reqwest_collector_client"] }
tracing-opentelemetry = "0.15.0"
tracing-subscriber = "0.2.20"

# Metrics
tari_metrics = { path = "../../infrastructure/metrics", optional = true, features = ["server"] }

Expand Down
1 change: 0 additions & 1 deletion applications/tari_base_node/src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ pub struct BaseNodeContext {
impl BaseNodeContext {
/// Waits for shutdown of the base node state machine and comms.
/// This call consumes the NodeContainer instance.
#[tracing::instrument(name = "base_node::wait_for_shutdown", skip(self))]
pub async fn wait_for_shutdown(self) {
self.state_machine().shutdown_signal().wait().await;
info!(target: LOG_TARGET, "Waiting for communications stack shutdown");
Expand Down
3 changes: 0 additions & 3 deletions applications/tari_base_node/src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@ pub(crate) struct Cli {
/// Create a default configuration file if it doesn't exist
#[clap(long)]
pub init: bool,
/// Enable tracing
#[clap(long, aliases = &["tracing", "enable-tracing"])]
pub tracing_enabled: bool,
/// This will rebuild the db, adding block for block in
// TODO: Should be a command rather
#[clap(long, alias = "rebuild_db")]
Expand Down
Loading