feat: remove extra validation #4981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes extra validation from transaction protocols.
Motivation and Context
The transaction protocols do a lot of extra unnecessary validation.
For example:
The code will run add_output(output), which will validate the range_proof and signatures.
The next line will run tx.build(), which will again validate the range_proof and signatures.
While these tests are not expensive, they are not free either.
The second problem is that when we do aggregate transactions such as with branch:
feature-m-of-nthese validations fail as the signatures are partial until right before we build the final transactionHow Has This Been Tested?
Passes all unit tests
Fixes: #4813