fix: wallet reuse existing tor address #5092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CjS77
added
P-acks_required
stringhandler
added
the
P-controversial
|
Labelling this as controversial. The fix is simple enough, but I have two concerns:
|
|
As to the second point. If only 1 client has the wrong address, then the client should update it and fix it with the incoming dial. Wallet could still send transactions as all transactions went through SAF, and SAF does not use the tor address for direct communication. |
SWvheerden
force-pushed
the
sw_fix_wallet_tor_id_reset
branch
2 times, most recently
from
72c573d to
69e7ef7
Compare
SWvheerden
force-pushed
the
sw_fix_wallet_tor_id_reset
branch
from
69e7ef7 to
111342e
Compare
|
Added a bit more resilience in #5142 to allow multiple addresses. Tested with a with a wallet turning off and on, getting a new tor address and it came online in time |
|
I'd like to merge #5142 first, since having this bug makes it easier to test |
stringhandler
approved these changes
Mar 6, 2023
stringhandler
pushed a commit
that referenced
this pull request
Mar 8, 2023
### ⚠ BREAKING CHANGES * **peer_db:** more accurate peer stats per address (5142) * use consensus hashing API for validator node MMR (5207) * **consensus:** add balanced binary merkle tree (5189) ### Features * add favourite flag to contact ([5217](#5217)) ([0371b60](0371b60)) * add indexer config ([5210](#5210)) ([cf95601](cf95601)) * add merge proof for balanced binary merkle tree ([5193](#5193)) ([8962909](8962909)) * **consensus:** add balanced binary merkle tree ([5189](#5189)) ([8d34e8a](8d34e8a)) * log to base dir ([#5197](#5197)) ([5147b5c](5147b5c)) * **peer_db:** more accurate peer stats per address ([5142](#5142)) ([fdad1c6](fdad1c6)) ### Bug Fixes * add grpc commitment signature proto type ([5200](#5200)) ([d523f1e](d523f1e)) * peer seeds for esme/igor ([5202](#5202)) ([1bc226c](1bc226c)) * remove panics from merged BBMT verification ([5221](#5221)) ([a4c5fce](a4c5fce)) * source coverage ci failure ([5209](#5209)) ([80294a1](80294a1)) * use consensus hashing API for validator node MMR ([5207](#5207)) ([de28115](de28115)) * wallet reuse existing tor address ([5092](#5092)) ([576f44e](576f44e)) * **wallet:** avoids empty addresses in node identity ([5224](#5224)) ([1a66312](1a66312))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes wallet to reuse existing tor address rather than create a new one each time it restarts
Motivation and Context
A wallet should not create a new tor address on startup, but rather reuse the existing ones.
How Has This Been Tested?
Manual
Fixes: #5089