chore(release): nextnet hotfix default network selection #5327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianp
force-pushed
the
fix-default-networks
branch
from
a1b0784 to
f475e35
Compare
brianp
changed the title
ghpbot-tari-project
added
P-acks_required
brianp
force-pushed
the
fix-default-networks
branch
from
f475e35 to
57e8ce3
Compare
brianp
changed the title
brianp
changed the title
SWvheerden
pushed a commit
that referenced
this pull request
Apr 17, 2023
Description --- Features is now a frequently used build dep in most our crates. Common actually also needs to be feature aware during build time. This means tari-features should have little to no dependencies, and especially none from our own crates. Motivation and Context --- Related to issue #5326 Related to nextnet hotfix #5327 How Has This Been Tested? --- Manually What process can a PR reviewer use to test or verify this change? --- Run cargo build with the desired network type (nextnet): `TARI_NETWORK=nextnet cargo build --bin tari_base_node` Run the bin directly without using cargo. It's important not to use cargo during the testing as the bin will likely rebuild when using `run` and change the previous `TARI_NETWORK` compilation settings: `./target/tari_base_node` See that the default network is NextNet. <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify
Remove common as dependency form tari-features Features is now a frequently used build dep in most of our crates. Common actually also needs to be feature aware during build time. This means tari-features should have little to no dependencies, especially none from our own crates. This caused a bug with the default network selection, as tari-feature wasn't successfully included in tari-common, causing the default network selection to downgrade its selection to TestNet regardless of the build.
brianp
force-pushed
the
fix-default-networks
branch
from
57e8ce3 to
2b507c2
Compare
|
This looks good, just needs to be updated to include: #5329 |
SWvheerden
approved these changes
Apr 18, 2023
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Features is now a frequently used build dep in most our crates. Common actually also needs to be feature aware during build time. This means tari-features should have little to no dependencies, and especially none from our own crates.
Motivation and Context
Related to #5326
Development fix: #5333
How Has This Been Tested?
Manually
What process can a PR reviewer use to test or verify this change?
Run cargo build with the desired network type (nextnet):
TARI_NETWORK=nextnet cargo build --bin tari_base_nodeRun the bin directly without using cargo. It's important not to use cargo during the testing as the bin will likely rebuild when using
runand change the previousTARI_NETWORKcompilation settings:./target/tari_base_nodeSee that the default network is NextNet.
Breaking Changes