fix(core): remove implicit change in protocol for partial/full signatures #5488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
sdbondi
force-pushed
the
core-tx-protocol-remove-full-sig-check
branch
from
9e6c71a to
ca62aee
Compare
sdbondi
force-pushed
the
core-tx-protocol-remove-full-sig-check
branch
from
ca62aee to
7a12c6c
Compare
sdbondi
changed the title
sdbondi
changed the title
| let received_output = &rec.output; | ||
| // we need to make sure we use our values here and not the received values. | ||
| let metadata_message = TransactionOutput::metadata_signature_message_from_parts( | ||
| &received_output.version, |
There was a problem hiding this comment.
Is it possible for a downgrade or other version mismatch to arise if the received output's version is not what the sender expected?
There was a problem hiding this comment.
This is now an issue.
There was a problem hiding this comment.
Thanks - completely agree there needs to be an explicit check for supported versions on both sides. FWIW currently, we have 1 enumerated version so I believe this can't be exploited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes check for an invalid signature, presumed to be a partial signature, which results in partial signature aggregation being skipped if a valid signature is passed in.
Motivation and Context
This check validates the receiver signature to determine if the signature is sent is partial or full. If partial we aggregate the sender and receiver partial signatures. A partial signature and an invalid signature run the same code path (
if received_output.verify_metadata_signature().is_err() {) This code branch is executed as part of every normal Tari transaction.It is not possible for the (non-local) receiver to unilaterally produce a correct signature and "bypass" aggregation as they do not possess the required secrets. The primary reason for this check is to allow the protocol to be shortcut when the sender and receiver are the same party and therefore can produce a valid signature (sign_as_sender_and_receiver). This PR implements this shortcut explicitly by adding a separate call for this case
add_presigned_recipient_info.How Has This Been Tested?
Existing transaction tests.
What process can a PR reviewer use to test or verify this change?
Send a normal and send-to-self transaction
Breaking Changes