fix(core/keymanager): use tokio rwlock for keymanagers #5494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
sdbondi
force-pushed
the
core-keymanager-use-tokio-lock
branch
from
973426b to
7603a03
Compare
sdbondi
force-pushed
the
core-keymanager-use-tokio-lock
branch
from
8a00028 to
adab71e
Compare
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces futures-rs Mutex with tokio's RwLock for key manager locks
Motivation and Context
Allow multiple concurrent reads for keymanagers. In general, we prefer to use tokio's locks with the tokio runtime (no investigation done into performance differences).
If there was a particular reason to use futures-rs Mutex we can close this.
How Has This Been Tested?
Existing tests, this change is not benchmarked.
What process can a PR reviewer use to test or verify this change?
Breaking Changes